Update comments around deprecated and inclusive naming #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavamsi
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah and
nhtruong
as code owners
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
feature/inclusive_naming
branch
from
8f2e330 to
d210ca4
Compare
harshavamsi
force-pushed
the
feature/inclusive_naming
branch
3 times, most recently
from
dff45c2 to
79ccb33
Compare
harshavamsi
force-pushed
the
feature/inclusive_naming
branch
2 times, most recently
from
e0d38a4 to
2407345
Compare
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
harshavamsi
force-pushed
the
feature/inclusive_naming
branch
from
2407345 to
ac31ec3
Compare
nhtruong
reviewed
Nov 17, 2022
nhtruong
reviewed
Nov 21, 2022
opensearch-api/lib/opensearch/api/actions/cluster/delete_component_template.rb
Show resolved
Hide resolved
nhtruong
reviewed
Nov 21, 2022
nhtruong
requested changes
Nov 21, 2022
opensearch-api/lib/opensearch/api/actions/cluster/put_component_template.rb
Show resolved
Hide resolved
opensearch-api/lib/opensearch/api/actions/dangling_indices/delete_dangling_index.rb
Show resolved
Hide resolved
opensearch-api/lib/opensearch/api/actions/dangling_indices/import_dangling_index.rb
Show resolved
Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
nhtruong
reviewed
Nov 21, 2022
nhtruong
reviewed
Nov 21, 2022
nhtruong
reviewed
Nov 21, 2022
opensearch-api/lib/opensearch/api/actions/snapshot/get_features.rb
Outdated
Show resolved
Hide resolved
nhtruong
reviewed
Nov 21, 2022
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
nhtruong
approved these changes
Nov 21, 2022
dblock
approved these changes
Nov 21, 2022
| es_version_info = client.info['version'] | ||
| version_number = es_version_info['number'] | ||
| build_hash = es_version_info['build_hash'] | ||
| os_version_info = client.info['version'] |
There was a problem hiding this comment.
We can change this later, but I think this should be opensearch_ because OS assumes operating system a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsha Vamsi Kalluri [email protected]
Description
master_timeouttocluster_manager_timeoutmastertocluster_manager2.1.0Issues Resolved
Closes #72
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.