Add Ruby 3.1 to the CI matrix #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Goldstein <[email protected]>
|
Previously run build showing that the '3.0' is being truncated to '3' and Ruby 3.1.1 is being loaded:
|
|
Thanks for this! That's one reason to put each version on its own line, but I guess it would be fairly long :) |
|
@petergoldstein Care to fix the link checker? Looks like |
Signed-off-by: Peter Goldstein <[email protected]>
|
@dblock I just pushed up a commit removing the dead link. Please let me know if you need anything else. Thanks. |
dblock
approved these changes
Mar 24, 2022
| @@ -20,7 +20,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ruby: [ 2.5, 2.6, 2.7, 3.0, jruby-9.3 ] | |||
| ruby: [ 2.5, 2.6, 2.7, '3.0', 3.1, jruby-9.3 ] | |||
There was a problem hiding this comment.
Why do we need to put 3.0 in single quotes ?
There was a problem hiding this comment.
See the comment and screenshot above in the PR. An unquoted 3.0 is truncated to 3.
There was a problem hiding this comment.
Ah my bad, didn't read the details. I thought we are only adding 3.1
jayeshathila
approved these changes
Mar 24, 2022
VachaShah
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Goldstein [email protected]
Description
Adds Ruby 3.1 to the CI matrix
Issues Resolved
Fixes a bug in the existing CI matrix. Github Actions will truncate an unquoted 3.0 to 3, and thus pull in the latest Ruby 3 version for that entry in the matrix. At this time that's Ruby 3.1.1, which is not what's intended. Adding quotes to the 3.0 resolves this issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.