[Backport 1.x] Faraday 2 support for opensearch-transport 2 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Faraday 2 support for opensearch-transport 2 - Support Faraday 1.x and 2.x in opensearch-transport. - Made client autodetection not break if the detected HTTP client is there but the associated Faraday adapter is not. - Made the test setup require the referenced adapters. - Made it more clear in the README that Faraday uses adapters. [Fixes #59] Signed-off-by: Brian Hawley <[email protected]> * Additional requested fixes - The Ruby < 2.7, Faraday 2+, and Typhoeus combination doesn't work. Adjusted the README and test setup accordingly. - Fix the MiniTest transport test setup. - Add extra opensearch-transport tests to the matrix for Faraday 1. Signed-off-by: Brian Hawley <[email protected]> * More requested fixes - Use Gem::Version comparison. - Fix the faraday-typhoeus links. Signed-off-by: Brian Hawley <[email protected]> * More fixes and requested changes - Move the Faraday 1 tests to their own job. - Don't reference faraday-typhoeus during Faraday 1 tests. - Use ENV.key?('FARADAY_VERSION'). Signed-off-by: Brian Hawley <[email protected]> * Make the version checks backwards compatible Signed-off-by: Brian Hawley <[email protected]> (cherry picked from commit 60840f7)
opensearch-trigger-bot
bot
requested review from
a team and
robsears
as code owners
|
@VachaShah the failures are the same "mydoc" failures that I had to fix in #75. Can I add the same fixes here? |
|
Looks like 1.x also needs a backport of #74. |
|
I did both changes in https://github.com/BrianHawley/opensearch-ruby/tree/backport/backport-76-to-1.x so they can be copied here. I can't push to this branch directly. I made #87 to add the commits through a PR, but you might not prefer to do it that way. |
* Remove deprecated escape_utils. (#74) Signed-off-by: Brian Hawley <[email protected]> * Backport test fixes from 2.0 Signed-off-by: Brian Hawley <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
dblock
approved these changes
Jul 6, 2022
VachaShah
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 60840f7 from #76