Bumping version to 2.0.1 for opensearch-transport #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
|
@BrianHawley I am not able to add you for reviewer, so tagging you here. |
dblock
approved these changes
Jul 22, 2022
| @@ -61,7 +61,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = '>= 2.4' | |||
|
|
|||
| s.add_dependency 'opensearch-transport', '2.0.0' | |||
| s.add_dependency 'opensearch-transport', '~> 2.0.0' | |||
There was a problem hiding this comment.
Curious why does the client rely on opensearch-transport?
There was a problem hiding this comment.
So the ruby client has 3 gems which are sub-gems kind of, opensearch-api, opensearch-transport and opensearch-dsl. They are all written in the client and created as separate gems plus they are used in the main gem which is the opensearch-ruby gem. So all the 3 gems can be used separately or can be used as part of the opensearch-ruby gem.
|
Looks good to me! |
saratvemulapalli
approved these changes
Jul 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2022
* Bumping version to 2.0.1 for opensearch-transport Signed-off-by: Vacha Shah <[email protected]> * Bumping version for opensearch-ruby to include transport version change Signed-off-by: Vacha Shah <[email protected]> (cherry picked from commit c90719e)
VachaShah
added a commit
that referenced
this pull request
Jul 25, 2022
* Bumping version to 2.0.1 for opensearch-transport Signed-off-by: Vacha Shah <[email protected]> * Bumping version for opensearch-ruby to include transport version change Signed-off-by: Vacha Shah <[email protected]> (cherry picked from commit c90719e) Co-authored-by: Vacha Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah [email protected]
Description
Bumping version to 2.0.1 for opensearch-transport.
Issues Resolved
#91
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.