[BUG-3581] [Code Style] HttpStatus & Headers should not be imported from org.apache.hc.core5.http - Header Refactor Only

[prabhask5]

Description

Accounts for refactor of Header classes from hc.core5.http to just http by adding checkstyle test, and manually refactoring all current occurrences of the illegal import. Additionally updated spotlessApply to make the refactor automatic on future cases of illegal import.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Bug fix/refactor

• Why these changes are required?

Refer to #3581

• What is the old behavior before changes and new behavior after changes?

Ideally nothing.

Issues Resolved

• [BUG] [Code Style] HttpStatus & Headers should not be imported from org.apache.hc.core5.http #3581

Is this a backport? If so, please add backport PR # and/or commits #
No.

Testing

Tests have been modified and should work before merging.

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[prabhask5]

@peternied @cwperks @scrawfor99 I refactored Header for this PR. In trying to fix the compiler issues that arose, I tried to change the import of BasicHeader from import org.apache.hc.core5.http.message.BasicHeader; to import org.apache.http.message.BasicHeader;. Let me know if this is a bad change to make. For four files the errors that arose were not because of this reason: OpensearchClientProvider.java, TestRestClient.java, MockSamlldpServer.java, RestHelper.java. It looks like for these files the error is trying to pass the new Header import into a function that only takes in the old Header import. I cannot change these functions because they are outside the security repo. Any other ideas on how to fix these?

[peternied]

@prabhask5, thanks for your work on the issue [1]. In open-source projects, contributors are expected to not just find issues but also seek solutions, deepening their understanding of the codebase. I suggest you further explore how your changes affect the existing code. If it's too complex, maybe try another project aspect. Remember, as maintainers, we guide and review, but you're responsible for developing and testing solutions.

We're here for feedback and help with any specific questions!

• [1] [BUG] [Code Style] HttpStatus & Headers should not be imported from org.apache.hc.core5.http #3581

[prabhask5]

@prabhask5, thanks for your work on the issue [1]. In open-source projects, contributors are expected to not just find issues but also seek solutions, deepening their understanding of the codebase. I suggest you further explore how your changes affect the existing code. If it's too complex, maybe try another project aspect. Remember, as maintainers, we guide and review, but you're responsible for developing and testing solutions.

We're here for feedback and help with any specific questions!

• [1] [BUG] [Code Style] HttpStatus & Headers should not be imported from org.apache.hc.core5.http #3581

@peternied Thanks for the comment, I’ll work to do so! Just to check though, is the basic header change a valid change in this context or should I figure this out without making any other import changes? Tysm!

[peternied]

Doesn't look like this is being worked on anymore, going to close this out. Please feel free to reopen if you re-engage on this @prabhask5