Plugin Security - Initial changes for roles injection #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skkosuri-amzn
commented
Jul 6, 2020
| @@ -22,4 +22,4 @@ java.version=1.8 | |||
| # elasticsearch release. This version is checked when the plugin | |||
| # is loaded so Elasticsearch will refuse to start in the presence of | |||
| # plugins with the incorrect elasticsearch.version. | |||
| elasticsearch.version=7.7.1 | |||
| elasticsearch.version=7.7.0 | |||
There was a problem hiding this comment.
Version change is only for testing on 7.7.0
skkosuri-amzn
commented
Jul 6, 2020
| @@ -68,7 +68,7 @@ | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <maven.compiler.release>8</maven.compiler.release> | |||
|
|
|||
| <elasticsearch.version>7.7.1</elasticsearch.version> | |||
| <elasticsearch.version>7.7.0</elasticsearch.version> | |||
There was a problem hiding this comment.
Version change is only for testing on 7.7.0
vrozov
reviewed
Jul 6, 2020
|
Creating PR's against master. |
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
…pensearch-project#546) * add instruction view for tenant list when multitenancy is disabled * wording update by UX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
To support below use cases:
opendistro-for-elasticsearch/alerting#6
opendistro-for-elasticsearch/alerting#215
Similar use cases are present for other plugins.
Description of changes:
/rolesinfo, REST and transport layer call. This call is used to get user and roles details of the logged on user. I couldn't use/authinfocall, as it doesn't have a transport layer call./rolesinfotransport layer call, had to moved the request, response, action classes to commons library. (opendistro-commons). That means security plugin will have dependency on this library.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.