Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless override #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Nov 7, 2024

Description

Allow overriding the default serverless detection logic. We need to rely on URL patterns since there's no real status checks available for Serverless.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
Copy link

@jduo jduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update README.md as well for the flag.

@Swiddis Swiddis marked this pull request as draft November 7, 2024 20:57
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Nov 12, 2024

Let's update README.md as well for the flag.

Didn't realize at the time that I also had to add it as a flag at all (head was in library mode), good catch -- added both the actual flag and a Readme line.

@Swiddis Swiddis marked this pull request as ready for review November 12, 2024 18:18
Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants