-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination: Remove getTotalHits
feature
#1649
Merged
MaxKsyunz
merged 2 commits into
opensearch-project:feature/pagination/integ
from
Bit-Quill:feature/pagination/remove-getTotalHits
May 30, 2023
Merged
Pagination: Remove getTotalHits
feature
#1649
MaxKsyunz
merged 2 commits into
opensearch-project:feature/pagination/integ
from
Bit-Quill:feature/pagination/remove-getTotalHits
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
MaxKsyunz
as code owners
May 23, 2023 18:00
Codecov Report
@@ Coverage Diff @@
## feature/pagination/integ #1649 +/- ##
==============================================================
- Coverage 97.23% 97.22% -0.01%
+ Complexity 4238 4229 -9
==============================================================
Files 385 385
Lines 10626 10612 -14
Branches 726 726
==============================================================
- Hits 10332 10318 -14
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
changed the title
Remove
Pagination: Remove May 23, 2023
getTotalHits
featuregetTotalHits
feature
GumpacG
approved these changes
May 24, 2023
penghuo
approved these changes
May 24, 2023
forestmvey
approved these changes
May 24, 2023
matthewryanwells
approved these changes
May 24, 2023
acarbonetto
reviewed
May 26, 2023
acarbonetto
approved these changes
May 26, 2023
12 tasks
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
force-pushed
the
feature/pagination/remove-getTotalHits
branch
from
May 30, 2023 05:07
36f7a61
to
c23e4d4
Compare
MaxKsyunz
approved these changes
May 30, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Paging thru
SELECT * FROM calcs
(17 rows) withfetch_size = 5
returns:Before
After
Issues Resolved
Fixes #1581
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.