Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: Remove getTotalHits feature #1649

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented May 23, 2023

Description

Paging thru SELECT * FROM calcs (17 rows) with fetch_size = 5 returns:
Before

  • Page 1: total hits = 17, result size = 5, cursor
  • Page 2: total hits = 17, result size = 5, cursor
  • Page 3: total hits = 17, result size = 5, cursor
  • Page 4: total hits = 17, result size = 2

After

  • Page 1: total hits = 5, result size = 5, cursor
  • Page 2: total hits = 5, result size = 5, cursor
  • Page 3: total hits = 5, result size = 5, cursor
  • Page 4: total hits = 2, result size = 2

Issues Resolved

Fixes #1581

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1649 (71d57a2) into feature/pagination/integ (bc5bede) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                      Coverage Diff                       @@
##             feature/pagination/integ    #1649      +/-   ##
==============================================================
- Coverage                       97.23%   97.22%   -0.01%     
+ Complexity                       4238     4229       -9     
==============================================================
  Files                             385      385              
  Lines                           10626    10612      -14     
  Branches                          726      726              
==============================================================
- Hits                            10332    10318      -14     
  Misses                            287      287              
  Partials                            7        7              
Flag Coverage Δ
sql-engine 97.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/planner/physical/CursorCloseOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/FilterOperator.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/NestedOperator.java 100.00% <ø> (ø)
.../opensearch/sql/planner/physical/PhysicalPlan.java 100.00% <ø> (ø)
...pensearch/sql/planner/physical/ValuesOperator.java 100.00% <ø> (ø)
...search/executor/protector/ResourceMonitorPlan.java 100.00% <ø> (ø)
...ch/sql/opensearch/response/OpenSearchResponse.java 100.00% <ø> (ø)
...l/opensearch/storage/scan/OpenSearchIndexScan.java 100.00% <ø> (ø)
...arch/storage/system/OpenSearchSystemIndexScan.java 100.00% <ø> (ø)
...opensearch/executor/OpenSearchExecutionEngine.java 100.00% <100.00%> (ø)
... and 2 more

@Yury-Fridlyand Yury-Fridlyand changed the title Remove getTotalHits feature Pagination: Remove getTotalHits feature May 23, 2023
@Yury-Fridlyand Yury-Fridlyand requested a review from anirudha as a code owner May 29, 2023 19:15
@Yury-Fridlyand Yury-Fridlyand added the pagination Pagination feature, ref #656 label May 29, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand force-pushed the feature/pagination/remove-getTotalHits branch from 36f7a61 to c23e4d4 Compare May 30, 2023 05:07
Signed-off-by: Yury-Fridlyand <[email protected]>
@MaxKsyunz MaxKsyunz merged commit 33dcc64 into opensearch-project:feature/pagination/integ May 30, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the feature/pagination/remove-getTotalHits branch May 30, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pagination Pagination feature, ref #656
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants