OCPBUGS-44305: Unable to remove finally tasks in pipeline builder mode

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-44305

Analysis / Root cause:
If all Finally tasks are removed, existing Pipeline Finally task was considered, so user was not able to remove all the Finally tasks

Solution Description:
Used finallyTasks from formData

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-11-07.at.12.41.30.PM.mov

---AFTER----

Screen.Recording.2024-11-07.at.12.43.27.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create a finally task in a pipeline in pipeline builder
2. Save pipeline
3. Edit pipeline and remove finally task in pipeline builder
4. Save pipeline
5. Observe that the finally task has not been removed

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-44305, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-44305

Analysis / Root cause:
If all Finally tasks are removed, existing Pipeline Finally task was considered, so user was not able to remove all the Finally tasks

Solution Description:
Used finallyTasks from formData

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-11-07.at.12.41.30.PM.mov

---AFTER----

Screen.Recording.2024-11-07.at.12.43.27.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create a finally task in a pipeline in pipeline builder
2. Save pipeline
3. Edit pipeline and remove finally task in pipeline builder
4. Save pipeline
5. Observe that the finally task has not been removed

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/retest

[logonoff]

verified changes locally

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [lokanandaprabhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c81de79 and 2 for PR HEAD 9af8591 in total

[logonoff]

/retest

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-44305: All pull requests linked via external trackers have merged:

• openshift/console#14472

Jira Issue OCPBUGS-44305 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-44305

Analysis / Root cause:
If all Finally tasks are removed, existing Pipeline Finally task was considered, so user was not able to remove all the Finally tasks

Solution Description:
Used finallyTasks from formData

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-11-07.at.12.41.30.PM.mov

---AFTER----

Screen.Recording.2024-11-07.at.12.43.27.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create a finally task in a pipeline in pipeline builder
2. Save pipeline
3. Edit pipeline and remove finally task in pipeline builder
4. Save pipeline
5. Observe that the finally task has not been removed

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202411212037.p0.gea76ee6.assembly.stream.el9.
All builds following this will include this PR.

[lokanandaprabhu]

/cherrypick release-4.17

[openshift-cherrypick-robot]

@lokanandaprabhu: new pull request created: #14527

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.