Skip to content

Commit

Permalink
Move pod_resize tests out of alpha
Browse files Browse the repository at this point in the history
  • Loading branch information
tallclair committed Nov 9, 2024
1 parent 479b300 commit 4bbc6f1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
3 changes: 1 addition & 2 deletions test/e2e/common/node/pod_resize.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/kubernetes/test/e2e/feature"
"k8s.io/kubernetes/test/e2e/framework"
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
Expand Down Expand Up @@ -1060,7 +1059,7 @@ func doPodResizeErrorTests(f *framework.Framework) {
// Above tests are performed by doSheduletTests() and doPodResizeResourceQuotaTests()
// in test/e2e/node/pod_resize.go

var _ = SIGDescribe("Pod InPlace Resize Container", framework.WithSerial(), feature.InPlacePodVerticalScaling, "[NodeAlphaFeature:InPlacePodVerticalScaling]", func() {
var _ = SIGDescribe("Pod InPlace Resize Container", framework.WithSerial(), func() {
f := framework.NewDefaultFramework("pod-resize-tests")

ginkgo.BeforeEach(func(ctx context.Context) {
Expand Down
3 changes: 0 additions & 3 deletions test/e2e/feature/feature.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,6 @@ var (
// Ingress.networking.k8s.io to be present.
Ingress = framework.WithFeature(framework.ValidFeatures.Add("Ingress"))

// TODO: document the feature (owning SIG, when to use this feature for a test)
InPlacePodVerticalScaling = framework.WithFeature(framework.ValidFeatures.Add("InPlacePodVerticalScaling"))

// Owner: sig-network
// Marks tests that require a cluster with dual-stack pod and service networks.
IPv6DualStack = framework.WithFeature(framework.ValidFeatures.Add("IPv6DualStack"))
Expand Down
5 changes: 2 additions & 3 deletions test/e2e/node/pod_resize.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
resourceapi "k8s.io/kubernetes/pkg/api/v1/resource"
"k8s.io/kubernetes/test/e2e/feature"
"k8s.io/kubernetes/test/e2e/framework"
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
Expand Down Expand Up @@ -356,7 +355,7 @@ func doPodResizeSchedulerTests(f *framework.Framework) {
})
}

var _ = SIGDescribe(framework.WithSerial(), "Pod InPlace Resize Container (scheduler-focused)", feature.InPlacePodVerticalScaling, func() {
var _ = SIGDescribe(framework.WithSerial(), "Pod InPlace Resize Container (scheduler-focused)", func() {
f := framework.NewDefaultFramework("pod-resize-scheduler-tests")
ginkgo.BeforeEach(func(ctx context.Context) {
node, err := e2enode.GetRandomReadySchedulableNode(ctx, f.ClientSet)
Expand All @@ -368,7 +367,7 @@ var _ = SIGDescribe(framework.WithSerial(), "Pod InPlace Resize Container (sched
doPodResizeSchedulerTests(f)
})

var _ = SIGDescribe("Pod InPlace Resize Container", feature.InPlacePodVerticalScaling, func() {
var _ = SIGDescribe("Pod InPlace Resize Container", func() {
f := framework.NewDefaultFramework("pod-resize-tests")

ginkgo.BeforeEach(func(ctx context.Context) {
Expand Down

0 comments on commit 4bbc6f1

Please sign in to comment.