Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2120: Add groupsnapshot tests #2155

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Dec 6, 2024

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations (applies only to 1.31)
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 6, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
Copy link

openshift-ci bot commented Dec 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • a027a96|128972: does not specify an upstream backport in the commit message
  • a21f7d6|: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Dec 6, 2024
@gnufied
Copy link
Member

gnufied commented Dec 6, 2024

Once 1.32 rebase lands we don't need kubernetes#126326 right?

@jsafrane
Copy link
Author

Yes, kubernetes#126326 is only for Kubernetes 1.31

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from a027a96 to 0711f08 Compare December 16, 2024 13:55
jsafrane added a commit to jsafrane/origin that referenced this pull request Dec 16, 2024
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from 0711f08 to 33cedfd Compare December 16, 2024 17:22
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from f09528f to 0279cb6 Compare January 2, 2025 14:24
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 2, 2025
@jsafrane jsafrane changed the title WIP: add groupsnapshot tests Add groupsnapshot tests Jan 6, 2025
Enable the group snapshot feature gate by default in e2e tests. It is
enabled in OCP 4.19 by default.

Carry until it's enabled similarly upstream or until it reaches GA.
@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from 0279cb6 to fbe715a Compare January 6, 2025 09:18
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane marked this pull request as ready for review January 6, 2025 09:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2025
@jsafrane jsafrane changed the title Add groupsnapshot tests STOR-2120: Add groupsnapshot tests Jan 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 + 128972 that add the e2e test. Only the second commit is needed in Kubernetes 1.32, but we still have 1.31 in o/k.
  • Regenerate test annotations.
  • In the last commit, force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases. This affects only e2e test manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations.
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Author

jsafrane commented Jan 6, 2025

/test

Copy link

openshift-ci bot commented Jan 6, 2025

@jsafrane: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test artifacts
/test configmap-scale
/test e2e-aws-crun-wasm
/test e2e-aws-jenkins
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-crun
/test e2e-aws-ovn-downgrade
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-runc
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-ovn-upgrade
/test images
/test integration
/test k8s-e2e-conformance-aws
/test k8s-e2e-gcp-ovn
/test k8s-e2e-gcp-serial
/test perfscale-control-plane-6nodes
/test unit
/test verify
/test verify-commits

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-ovn
/test e2e-aws-single-node
/test e2e-azure
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-csi-cinder
/test e2e-openstack-csi-manila
/test e2e-vsphere
/test k8s-e2e-aws
/test k8s-e2e-aws-ovn-serial
/test k8s-e2e-gcp-five-control-plane-replicas
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kubernetes-master-artifacts
pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm
pull-ci-openshift-kubernetes-master-e2e-aws-csi
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-runc
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-e2e-gcp
pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-kubernetes-master-images
pull-ci-openshift-kubernetes-master-integration
pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
pull-ci-openshift-kubernetes-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-kubernetes-master-unit
pull-ci-openshift-kubernetes-master-verify
pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsafrane jsafrane closed this Jan 6, 2025
@jsafrane jsafrane reopened this Jan 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations.
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Author

jsafrane commented Jan 6, 2025

/test help

Copy link

openshift-ci bot commented Jan 6, 2025

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test artifacts
/test configmap-scale
/test e2e-aws-crun-wasm
/test e2e-aws-jenkins
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-crun
/test e2e-aws-ovn-downgrade
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-runc
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-ovn-upgrade
/test images
/test integration
/test k8s-e2e-conformance-aws
/test k8s-e2e-gcp-ovn
/test k8s-e2e-gcp-serial
/test perfscale-control-plane-6nodes
/test unit
/test verify
/test verify-commits

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-ovn
/test e2e-aws-single-node
/test e2e-azure
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-csi-cinder
/test e2e-openstack-csi-manila
/test e2e-vsphere
/test k8s-e2e-aws
/test k8s-e2e-aws-ovn-serial
/test k8s-e2e-gcp-five-control-plane-replicas
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kubernetes-master-artifacts
pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm
pull-ci-openshift-kubernetes-master-e2e-aws-csi
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-runc
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-e2e-gcp
pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-kubernetes-master-images
pull-ci-openshift-kubernetes-master-integration
pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial
pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn
pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
pull-ci-openshift-kubernetes-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-kubernetes-master-unit
pull-ci-openshift-kubernetes-master-verify
pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsafrane
Copy link
Author

jsafrane commented Jan 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

Copy link

openshift-ci bot commented Jan 6, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fa4ce60-cc27-11ef-828f-00c71570a3e5-0

Copy link

openshift-ci bot commented Jan 6, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips fbe715a link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-cgroupsv2 fbe715a link true /test e2e-aws-ovn-cgroupsv2
ci/prow/okd-scos-e2e-aws-ovn fbe715a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-crun fbe715a link true /test e2e-aws-ovn-crun
ci/prow/e2e-aws-crun-wasm fbe715a link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-runc fbe715a link true /test e2e-aws-ovn-runc
ci/prow/e2e-aws-ovn-serial fbe715a link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp fbe715a link true /test e2e-gcp
ci/prow/k8s-e2e-gcp-ovn fbe715a link true /test k8s-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations (applies only to 1.31)
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations (applies only to 1.31)
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 10, 2025
@jsafrane
Copy link
Author

/retest

@jsafrane
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm,periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6,periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

Copy link

openshift-ci bot commented Jan 13, 2025

@jsafrane: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@jsafrane
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

Copy link

openshift-ci bot commented Jan 13, 2025

@jsafrane: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8de11d70-d1ae-11ef-9bb3-366aa9ecbf72-0

@jsafrane
Copy link
Author

A lot of tests failed because of they failed to pull images, e.g.
Failed: Failed to pull image "quay.io/openshift/community-e2e-images:e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE": initializing source docker://quay.io/openshift/community-e2e-images:e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE: reading manifest e2e-53-registry-k8s-io-e2e-test-images-busybox-1-29-2-ZYWRth-o9U_JR2ZE in quay.io/openshift/community-e2e-images: manifest unknown

@jsafrane
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

I added a commit with new images

Copy link

openshift-ci bot commented Jan 14, 2025

@jsafrane: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77176fd0-d286-11ef-966b-e2b60ed3df72-0

jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants