Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add osde2e tests harness #334

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add osde2e tests harness #334

wants to merge 9 commits into from
+697 −115

Conversation

YiqinZhang
Copy link
Contributor

@YiqinZhang YiqinZhang commented Nov 6, 2024 •
edited by openshift-ci bot
Loading

SDCICD-1396

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YiqinZhang
Once this PR has been reviewed and has the lgtm label, please assign wanghaoran1988 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YiqinZhang YiqinZhang force-pushed the sdcicd-1396 branch 2 times, most recently from cdd345a to 5d2f5f6 Compare November 8, 2024 04:50
jbpratt added a commit to jbpratt/managed-cluster-validating-webhooks that referenced this pull request Nov 11, 2024
@jbpratt
misc: bump controller-runtime -> v0.15.1
1992db6 
NewDecoder no longer returns an error and instead panics if the scheme
is nil. It previously always returned a nil error

https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/webhook/admission#NewDecoder

https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/webhook/admission#Decoder.Decode

to reproduce:

```
go get sigs.k8s.io/[email protected]
```

then resolve build errors

required for openshift#334

Signed-off-by: Brady Pratt <[email protected]>
@jbpratt jbpratt mentioned this pull request Nov 11, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@jbpratt
Copy link
Contributor

jbpratt commented Nov 18, 2024

/hold

go get github.com/openshift/[email protected]

pull this version of osde2e-common so it doesn't bump controller-runtime even further

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@YiqinZhang YiqinZhang changed the title WIP Add osde2e tests harness Add osde2e tests harness Nov 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@YiqinZhang
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@jbpratt
Copy link
Contributor

jbpratt commented Nov 19, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisa lisa Awaiting requested review from lisa

@robotmaxtron robotmaxtron Awaiting requested review from robotmaxtron

@jbpratt jbpratt Awaiting requested review from jbpratt

Assignees
No one assigned
Labels
tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YiqinZhang @jbpratt @openshift-merge-robot