Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Escape key should close the overlay #326

Closed
spadgett opened this issue Jun 23, 2017 · 4 comments
Closed

Accessibility: Escape key should close the overlay #326

spadgett opened this issue Jun 23, 2017 · 4 comments
Assignees
@jeff-phillips-18
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3

Comments

@spadgett
Copy link
Member

Suggested by @ncameronbritt, and I've had the same thought. I've tried to close the overlay with the escape key before, and it doesn't work. It's potentially an accessibility issue and inconsistent with our other Bootstrap modals.

Maybe we can optionally prompt if the user has typed something.

cc @openshift/team-ux-review
@spadgett spadgett added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Jun 23, 2017
@spadgett spadgett mentioned this issue Jul 5, 2017
Closed
@beanh66
Copy link

beanh66 commented Oct 13, 2017

@spadgett makes sense to me to allow users to press esc to close the wizard when changes have not been made.

@serenamarie125
Copy link

@jeff-phillips-18 should this behavior be built into the Angular PatternFly Overlay Modal?

@jeff-phillips-18
Copy link
Member

@serenamarie125 yes

@jeff-phillips-18 jeff-phillips-18 self-assigned this Oct 13, 2017
@spadgett
Copy link
Member Author

@jeff-phillips-18 FYI, we have an on-esc directive that should make this relatively easy.

https://github.com/openshift/origin-web-console/blob/master/app/scripts/directives/util.js#L223-L234

jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-catalog that referenced this issue Oct 16, 2017
@jeff-phillips-18
Close the overlay panel on ESC
4390725 
Fixes openshift#326
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Oct 16, 2017
Merged
jeff-phillips-18 added a commit to jeff-phillips-18/origin-web-catalog that referenced this issue Oct 17, 2017
@jeff-phillips-18
Close the overlay panel on ESC
36531c9 
Fixes openshift#326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spadgett @jeff-phillips-18 @serenamarie125 @beanh66