Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox filter spacing #519

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Fix checkbox filter spacing #519

merged 1 commit into from
Oct 20, 2017

Conversation

spadgett
Copy link
Member

Fixes #504

screen shot 2017-10-20 at 6 24 32 pm

@spadgett spadgett requested a review from jwforres October 20, 2017 22:31
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2017
@serenamarie125
Copy link

@spadgett this looks much better !

@jwforres
Copy link
Member

LGTM but Travis is failing

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2017
@spadgett
Copy link
Member Author

spadgett commented Oct 20, 2017 •
edited
Loading

Fixed Travis failure (needed to call trim() in the unit test on the vendor text due to added whitespace)

@spadgett spadgett merged commit a22fd27 into openshift:master Oct 20, 2017
@spadgett spadgett deleted the checkbox-styles branch October 20, 2017 23:17
@spadgett spadgett mentioned this pull request Nov 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @serenamarie125 @jwforres @openshift-ci-robot