Don't move "Try Sample Repository" link when clicked #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
jwforres
approved these changes
Oct 25, 2017
|
lgtm but travis is failing |
Only show the name error message in the create from builder dialog if the user has typed something into the field. This avoids a problem where clicking the "Try Sample Repository" link doesn't work because the error message on name input blur causes the link to move.
spadgett
force-pushed
the
try-sample-link-moves
branch
from
e2339a3 to
34721d0
Compare
|
Thanks, I updated the dist |
|
Passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the name error message in the create from builder dialog if
the user has typed something into the field. This avoids a problem where
clicking the "Try Sample Repository" link doesn't work because the error
message on name input blur causes the link to move.
Fixes #497
/assign @jwforres