-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: PVC DataSource support #23241
Conversation
Hi @j-griffith. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: j-griffith The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eparis PTAL when you get a chance |
This pulls in support for specifying object of kind `PersistentVolumeclaim` as a DataSource in pvc create manifests, enabling clone operations for CSI plugins that support it.
@j-griffith i think we need an upstream PR to add to the UPSTREAM: <PR#> part of this, then we can review / merge this.. (assuming its landed upstream as is being cherry picked now). |
@childsb There were two PR's associated with this: and a fix for this and the Snapshots DS feature: kubernetes/kubernetes#78997 Also, this feature has been marked for Beta in 1.16 with no changes since it's introduction. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
I believe we already have DataSource support in 4.3 and 4.2 /close |
@jsafrane: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pulls in support for specifying object of kind
PersistentVolumeclaim
as a DataSource in pvc create manifests,enabling clone operations for CSI plugins that support it.
This PR does not enable the featuregate but just pulls it in to the vendored k8s base.