Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: PVC DataSource support #23241

Closed
wants to merge 1 commit into from

Conversation

j-griffith
Copy link

This pulls in support for specifying object of kind
PersistentVolumeclaim as a DataSource in pvc create manifests,
enabling clone operations for CSI plugins that support it.

This PR does not enable the featuregate but just pulls it in to the vendored k8s base.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jun 21, 2019
@openshift-ci-robot
Copy link

Hi @j-griffith. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: j-griffith
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@j-griffith
Copy link
Author

@eparis PTAL when you get a chance

@j-griffith j-griffith changed the title UPSTREAM:<carry>: PVC DataSource support UPSTREAM: <carry>: PVC DataSource support Jun 21, 2019
This pulls in support for specifying object of kind
`PersistentVolumeclaim` as a DataSource in pvc create manifests,
enabling clone operations for CSI plugins that support it.
@childsb
Copy link
Contributor

childsb commented Jul 11, 2019

@j-griffith i think we need an upstream PR to add to the UPSTREAM: <PR#> part of this, then we can review / merge this.. (assuming its landed upstream as is being cherry picked now).

@j-griffith
Copy link
Author

j-griffith commented Jul 12, 2019

@childsb There were two PR's associated with this:
The original feature impl: kubernetes/kubernetes#76913

and a fix for this and the Snapshots DS feature: kubernetes/kubernetes#78997

Also, this feature has been marked for Beta in 1.16 with no changes since it's introduction.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2019
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 9, 2019
@jsafrane
Copy link
Contributor

I believe we already have DataSource support in 4.3 and 4.2

/close

@openshift-ci-robot
Copy link

@jsafrane: Closed this PR.

In response to this:

I believe we already have DataSource support in 4.3 and 4.2

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants