-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48629: Use max time for netpol pods curl requests #29457
base: master
Are you sure you want to change the base?
Conversation
The curl request is seen as waiting indefinitely though connect time set to 1s, so using max time for connect reestablishment to happen upon a failure. Signed-off-by: Periyasamy Palanisamy <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pperiyasamy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-ovn-techpreview |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview |
@pperiyasamy: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cbea2800-d7f3-11ef-816b-9cb169aae18f-0 |
/retitle OCPBUGS-48629: Use max time for netpol pods curl requests |
@pperiyasamy: This pull request references Jira Issue OCPBUGS-48629, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial-techpreview |
@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial-techpreview 1 |
@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
/test e2e-aws-ovn-techpreview-serial |
@jluhrsen: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-techpreview-serial |
@jluhrsen: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial |
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e99b0f70-d863-11ef-9c24-b382e7199e89-0 |
@pperiyasamy , correct me if I'm wrong but this change will only affect the "serial" suite right? if so, then we can double check what the above looks like with techpreview. the test case(s) did pass fine in the non-techpreview serial job here, so at least we know the --max config is working there. Probably good enough to merge this PR IMHO, but might as well take a look at techpreview as well. |
Job Failure Risk Analysis for sha: f79f4e6
|
The curl request is seen as waiting indefinitely though connect time set to 1s, so using max time for connect reestablishment to happen upon a failure.
Flaky job link: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview/1879675595101573120