Patryk orphan removal #1160
Patryk orphan removal #1160
Conversation
…renced non-root objects. Signed-off-by: Patryk Diak <[email protected]>
This is a POC change, where egressip will explicitly remove the logical router policy when logical router no longer uses it. Currently in 4.10, the implementation expects ovsdb server to automatically garbage collect it, since that is a non-root table. NOTE: This change will break unit tests, since libovsdb ovsdb server used does not have garbage collection. See: ovn-org/libovsdb#219 Signed-off-by: Flavio Fernandes <[email protected]>
|
@flavio-fernandes: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavio-fernandes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
@flavio-fernandes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/close |
|
@flavio-fernandes: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
WIP: Do not merge: egressip: explicitly remove logical router policy
This is a POC change, where egressip will explicitly remove the logical router policy
when logical router no longer uses it. Currently in 4.10, the implementation expects
ovsdb server to automatically garbage collect it, since that is a non-root table.
NOTE: This change will break unit tests, since libovsdb ovsdb server used does not have
garbage collection. See: ovn-org/libovsdb#219