Boilerplate update #188
Boilerplate update #188
Conversation
|
@rojasreinold: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 46.54% 46.54%
=======================================
Files 9 9
Lines 752 752
=======================================
Hits 350 350
Misses 392 392
Partials 10 10
|
| @@ -25,13 +25,9 @@ export REPLACE_FUNC=$(echo "$REPLACE_SPECNAME" | sed 's/ //g' ) | |||
|
|
|||
| mkdir -p $HARNESS_DIR | |||
|
|
|||
| E2E_SUITE_BUILDER_IMAGE="registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.22-openshift-4.17" | |||
| if [[ -n ${KONFLUX_BUILDS} ]]; then | |||
| E2E_SUITE_BUILDER_IMAGE="brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_1.22" | |||
There was a problem hiding this comment.
Just want to make sure if Konflux build and normal build will use the same base image
There was a problem hiding this comment.
@tkong-redhat I would think so. These changes are from biolerplate updates, and I think some other operators have been promoted such as route monitor https://github.com/openshift/route-monitor-operator/blob/master/boilerplate/openshift/golang-osd-operator-osde2e/e2e-harness-generate.sh#L26
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a7vicky, rojasreinold The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
bug
What this PR does / why we need it?
Boilerplate update to address CVE's
Which Jira/Github issue(s) this PR fixes?
https://issues.redhat.com/browse/OSD-26520
Fixes #
Special notes for your reviewer:
Pre-checks (if applicable):