Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove approve/lgtm and Prow merge handling from coreos/ GH repos #16910

Merged

Conversation

cgwalters
Copy link
Member

Following the plan in coreos/fedora-coreos-tracker#764
we will continue to use Prow to run tests, but not as a merge bot.

Following the plan in coreos/fedora-coreos-tracker#764
we will continue to use Prow to run tests, but not as a merge bot.
@jlebon
Copy link
Member

jlebon commented Mar 17, 2021

/approve

Will let at least one other CoreOS team member /lgtm.

@miabbott
Copy link
Member

Something meta about using

/lgtm

...to remove the use of /lgtm

@wking
Copy link
Member

wking commented Mar 24, 2021

Abusing my Prow-config approver powers (which are supposed to just be for Boskos config touches), but this looks fine to me.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon, miabbott, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6b145c1 into openshift:master Mar 24, 2021
@openshift-ci-robot
Copy link
Contributor

@cgwalters: Updated the following 4 configmaps:

  • config configmap in namespace ci at cluster api.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • plugins configmap in namespace ci at cluster api.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml

In response to this:

Following the plan in coreos/fedora-coreos-tracker#764
we will continue to use Prow to run tests, but not as a merge bot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants