Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to test CI #133

Closed
wants to merge 3 commits into from
Closed

PR to test CI #133

wants to merge 3 commits into from

Conversation

nikhil-thomas
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2019
@nikhil-thomas nikhil-thomas self-assigned this Sep 16, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhil-thomas
To complete the pull request process, please assign arilivigni
You can assign the PR to them by writing /assign @arilivigni in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhil-thomas nikhil-thomas added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2019
@nikhil-thomas
Copy link
Member Author

/retest

@nikhil-thomas
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2019
@openshift-ci-robot
Copy link

The following users are mentioned in OWNERS file(s) but are not members of the openshift org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • piyush-garg
    • OWNERS_ALIASES
  • pradeepitm12
    • OWNERS_ALIASES

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 19, 2019
@nikhil-thomas
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2019
@nikhil-thomas
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2019
@nikhil-thomas
Update TestSidecarTaskSupport test
a3a8f52 
Update condition which checks sidecar termination

Signed-off-by: Nikhil Thomas <[email protected]>
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2019
@alanfx alanfx force-pushed the release-next branch 4 times, most recently from cb8c989 to 0f41945 Compare September 25, 2019 00:02
@nikhil-thomas
Copy link
Member Author

closing this PR as the causefor the sidecar test fail was identified and reported
tektoncd#1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmouel chmouel Awaiting requested review from chmouel

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@nikhil-thomas nikhil-thomas

Labels
do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhil-thomas @openshift-ci-robot @alanfx