Update base image of nop Dockerfile #135
Conversation
Sidecar tests are failing on CI. The tests fails when the nop images are involved. The nop image built by CI uses `ubi` as the base image as it specified so in the generated Dockerfile for nop image In local testing I could observe that the sidecar tests pass whe `scratch` is used as the base image for nop. Upstream also seems to be using scratch as their base image for `nop` image Hence, the purpiose of this patch to test whether changing the nop image base to `scratch` will make the sidecar test pass on ci
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nikhil-thomas: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alanfx
force-pushed
the
release-next
branch
2 times, most recently
from
cb8c989 to
0f41945
Compare
|
closing this PR as the causefor the sidecar test fail was identified and reported |
Sidecar tests are failing on CI.
The tests fails when the nop images are involved.
The nop image built by CI uses
ubias the base image as it specified soin the generated Dockerfile for nop image
In local testing I could observe that the sidecar tests pass whe
scratchis usedas the base image for nop. Upstream also seems to be using scratch as their base image for
nopimageHence, the purpiose of this patch to test whether changing the nop image base to
scratchwill make the sidecar test pass on ci