Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add audio link #27

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Oct 9, 2022

No description provided.

@vercel
Copy link

vercel bot commented Oct 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
opensource-f2f-website ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 2:16AM (UTC)

@sxzz
Copy link
Member

sxzz commented Oct 9, 2022

I don't think the title should be linked to the audio website. It's pretty weird behavior.

@LinuxSuRen
Copy link
Member Author

@sxzz Any suggestion? I'm just thinking about how to jump to the link.

@sxzz
Copy link
Member

sxzz commented Oct 10, 2022

Maybe we can add some platform icons (like 小宇宙、喜马拉雅) below author badges.

@LinuxSuRen
Copy link
Member Author

Which one do you prefer putting those icon files into this project or just referencing them?

@sxzz
Copy link
Member

sxzz commented Oct 10, 2022

I think we could put links to frontmatter of markdown file and put the icons into this project.

@LinuxSuRen
Copy link
Member Author

hi @sxzz , how about this one? We could add more icons here.

image

@sxzz
Copy link
Member

sxzz commented Oct 12, 2022

@LinuxSuRen Looks good! I just improved your codes.

@sxzz sxzz changed the title feat: add a link for the indvidual audio link feat: add audio link Oct 12, 2022
@sxzz sxzz merged commit 5174614 into opensource-f2f:main Oct 12, 2022
@LinuxSuRen LinuxSuRen deleted the feat/audio-link branch October 12, 2022 07:38
height="20"
mobile_small="30"
/>
<div flex justify-center my-2>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned from here. This is much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants