Skip to content

Commit

Permalink
add pyproject.toml to support pip 23.1
Browse files Browse the repository at this point in the history
pip 23.1 removed the "setup.py install" fallback for projects
that do not have pyproject.toml and now uses a pyproject.toml
which is vendored in pip.
To address that, this change adds the minimal pyproject.toml
to enable pbr to be properly used to build editable wheels.

This is required to support installing devstack on
centos stream 9 and related distros with GLOBAL_VENV=True
Without this change the wsgi scripts are not generated in
editable mode. i.e. pip install -e /opt/stack/keystone

See https://pip.pypa.io/en/stable/news/#v23-1
and pypa/pip#8368 for more
details on the removal of the fallback support.

setuptools v64.0.0 is used to support editable installs
via its PEP-660 implmentation
pypa/setuptools#3488

This patch was taken nearly verbatim from the equivalent nova change.

Co-Authored-By: Sean Mooney <[email protected]>
Change-Id: I34888e8f87b4a3ab09546ba58ef5f2cf495bc7e3
  • Loading branch information
2 people authored and cardoe committed Nov 5, 2024
1 parent 6f4e679 commit 6008d31
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["pbr>=6.0.0", "setuptools>=64.0.0"]
build-backend = "pbr.build"
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# date but we do not test them so no guarantee of having them all correct. If
# you find any incorrect lower bounds, let us know or propose a fix.

pbr>=3.1.1 # Apache-2.0
pbr>=6.0.0 # Apache-2.0
SQLAlchemy>=1.4.0 # MIT
alembic>=1.4.2 # MIT
automaton>=1.9.0 # Apache-2.0
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
import setuptools

setuptools.setup(
setup_requires=['pbr>=2.0.0'],
setup_requires=['pbr>=6.0.0'],
pbr=True,
)

0 comments on commit 6008d31

Please sign in to comment.