change subject to subject interest on lead creation, fix lead spec

openstax · Oct 30, 2023 · 2b757ff · 2b757ff
1 parent ecdf543
commit 2b757ff
Show file tree

Hide file tree

Showing 5 changed files with 81 additions and 15 deletions.
diff --git a/app/routines/newflow/create_salesforce_lead.rb b/app/routines/newflow/create_salesforce_lead.rb
@@ -50,7 +50,7 @@ def exec(user:)
         position: sf_position,
         title: user.other_role_name,
         who_chooses_books: user.who_chooses_books,
-        subject: user.which_books,
+        subject_interest: user.which_books,
         num_students: user.how_many_students,
         adoption_status: ADOPTION_STATUS_FROM_USER[user.using_openstax_how],
         adoption_json: adoption_json,

diff --git a/spec/cassettes/Newflow_CreateSalesforceLead/sf_setup.yml b/spec/cassettes/Newflow_CreateSalesforceLead/sf_setup.yml
diff --git a/spec/cassettes/Newflow_CreateSalesforceLead/works_on_the_happy_path.yml b/spec/cassettes/Newflow_CreateSalesforceLead/works_on_the_happy_path.yml
diff --git a/spec/routines/newflow/create_salesforce_lead_spec.rb b/spec/routines/newflow/create_salesforce_lead_spec.rb
@@ -34,16 +34,12 @@ module Newflow
       end
     end
 
-    xit 'works on the happy path' do
+    it 'works on the happy path' do
       expect(Rails.logger).not_to receive(:warn)
 
       lead = described_class[user: user]
-      expect(lead.errors).to be_empty
 
-
-      lead_from_sf = user.lead
-      expect(lead_from_sf).not_to be_nil
-      expect(lead_from_sf.application_source).to eq "Account Creation"
+      expect(user.salesforce_lead_id).not_to be_nil
     end
   end
 end
diff --git a/spec/vcr_helper.rb b/spec/vcr_helper.rb
@@ -54,6 +54,7 @@ def filter_secret(path_to_secret)
 
   %w(
     instance_url
+    login_domain
     username
     password
     security_token