Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center progressbar nav and add padding #75

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Center progressbar nav and add padding #75

merged 3 commits into from
Oct 22, 2024

Conversation

jivey
Copy link
Member

@jivey jivey commented Oct 16, 2024

The mobile view for the ProgressBar nav needs some room to prevent mistaps, and centering it makes it look better when there aren't many items.

Before:
image

After:
image

@jivey jivey requested a review from a team as a code owner October 16, 2024 20:39
@jivey jivey requested review from RoyEJohnson and removed request for a team October 16, 2024 20:39
RoyEJohnson
RoyEJohnson approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better with the padding.

@jivey jivey merged commit 95c954b into main Oct 22, 2024
1 check passed
@jivey jivey deleted the nav-padding branch October 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyEJohnson RoyEJohnson RoyEJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jivey @RoyEJohnson