refactor carnival tables #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswanson33
commented
Jul 15, 2024
There was a problem hiding this comment.
so many styles refactored! 🎉
overall, needs another pass to look at some issues with selectors and using color/font variables. i wonder if a point of confusion comes from the sass docs on nesting selectors ... the SCSS and Sass tabs show similar syntax, but Sass doesn't use {}. we are using SCSS -- be careful not to mix the two syntaxes, use {} consistently
jbwilson8
force-pushed
the
nursing-internal-tables
branch
from
c660816 to
e5e5705
Compare
…basic table shape in carnival
…table shapes in carnival
jbwilson8
force-pushed
the
nursing-internal-tables
branch
from
e5e5705 to
10f6e25
Compare
kswanson33
commented
Jul 25, 2024
this was separated into 2 separate files (_colors.scss and _fonts.scss
kswanson33
commented
Jul 25, 2024
|
Latest view of table header in Clinical Nursing: 
|
kswanson33
commented
Aug 8, 2024
There was a problem hiding this comment.
very close, i can see why it might be pretty difficult to identify the inconsistencies in the output ... need a better solution for this
update: https://github.com/openstax/cnx-recipes/issues/5596
Created a mixin for tables with exercises in general and removed the table-top-spacing() mixin.
jbwilson8
force-pushed
the
nursing-internal-tables
branch
from
80709ab to
ad64974
Compare
kswanson33
commented
Aug 9, 2024
kswanson33
commented
Aug 9, 2024
kswanson33
commented
Aug 9, 2024
kswanson33
commented
Aug 9, 2024
…/ce-styles into nursing-internal-tables
sparksam
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 5494