Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nursing Internal - Medical Surgical Nursing - Enable Column Width Proportional Values #554

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sparksam
Copy link
Contributor

@sparksam sparksam commented Sep 9, 2024

Copy link
Contributor

@TylerZeroMaster TylerZeroMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure, but I think some these new components may be unneeded since their data-ratio does not contain the associated col width ratio. I think, if I am correct, it will only result in redundant styles, so I am going to approve and let you decide.

Possible extra components
(carnival)
$Columns--ThreeColumnsSevenRatioOneB
$Columns--ThreeColumnsEightRatioOne
(webview)
$Columns--ThreeColumnsSevenRatioOneB
$Columns--ThreeColumnsEightRatioOne

@sparksam sparksam merged commit 7d9bc1b into main Sep 9, 2024
2 checks passed
@sparksam sparksam deleted the sk_ce_5607 branch September 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants