Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Wagtail 4.0.4 upgrade #1480

Merged
merged 7 commits into from
Oct 20, 2023
Merged

WIP - Wagtail 4.0.4 upgrade #1480

merged 7 commits into from
Oct 20, 2023

Conversation

edwoodward
Copy link
Contributor

@edwoodward edwoodward commented Jul 10, 2023

Read the upgrade instructions before using this branch.

Wagtail 4.0.4 UI Changes documentation

@edwoodward edwoodward self-assigned this Jul 10, 2023
@edwoodward edwoodward changed the title Wagtail 4.0.4 upgrade WIP - Wagtail 4.0.4 upgrade Jul 11, 2023
@edwoodward edwoodward requested a review from mwvolo July 11, 2023 16:33
@edwoodward edwoodward linked an issue Jul 11, 2023 that may be closed by this pull request
@mwvolo
Copy link
Member

mwvolo commented Jul 13, 2023

The upgrade instructions are well written. I followed them, had a handful of pages with no type, so I deleted them. Updated, then ran migrations with no issues! LGTM!

@@ -54,6 +55,7 @@
# route everything to /api/spike also...
path('apps/cms/api/spike/', include(wagtail_urls)),
path('sitemap.xml', sitemap),
#path(r'', include(wagtailimportexport_urls)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this package being removed later?

@edwoodward edwoodward force-pushed the wagtail-4.0.4-upgrade branch from 09f8cd1 to 813a2da Compare August 3, 2023 18:58
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1480 (8a86862) into development (e9ba3ac) will decrease coverage by 0.02%.
The diff coverage is 90.00%.

@@               Coverage Diff               @@
##           development    #1480      +/-   ##
===============================================
- Coverage        81.55%   81.53%   -0.02%     
===============================================
  Files              118      116       -2     
  Lines             6473     6472       -1     
===============================================
- Hits              5279     5277       -2     
- Misses            1194     1195       +1     

@edwoodward edwoodward force-pushed the wagtail-4.0.4-upgrade branch from 813a2da to 4bcd797 Compare August 30, 2023 13:28
@edwoodward edwoodward force-pushed the wagtail-4.0.4-upgrade branch from 4bcd797 to a46d62a Compare October 2, 2023 14:43
@edwoodward edwoodward force-pushed the wagtail-4.0.4-upgrade branch from a46d62a to 8a86862 Compare October 10, 2023 15:07
@edwoodward edwoodward merged commit 80e330e into development Oct 20, 2023
@edwoodward edwoodward deleted the wagtail-4.0.4-upgrade branch October 20, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Wagtail 4.04
2 participants