Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RootPage and FlexPage types to support new homepage (and more) #1567

Merged
merged 47 commits into from
Jul 25, 2024

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Jun 28, 2024

No description provided.

@mwvolo mwvolo force-pushed the customizable-pages branch from 02c3499 to 973220e Compare June 28, 2024 01:45
pages/custom_blocks.py Outdated Show resolved Hide resolved
pages/custom_blocks.py Outdated Show resolved Hide resolved
pages/models.py Outdated Show resolved Hide resolved
snippets/models.py Outdated Show resolved Hide resolved
@TomWoodward
Copy link
Member

also, every link we have should always have link_text, link_url, and link_aria_label, should we make a composable block so that we don't always have to have all three urls on everything? looking at the fields on the hero for primary/secondary cta, it seems like it might help

@mwvolo
Copy link
Member Author

mwvolo commented Jun 28, 2024

@TomWoodward should any of those be required? Like the aria_label?

@TomWoodward
Copy link
Member

aria-label for links can be optional, its just commonly needed when like 7 links on the page's text are "read more"

pages/models.py Outdated Show resolved Hide resolved
@mwvolo mwvolo changed the title Customizable pages New RootPage and FlexPage types to support new homepage (and more) Jul 22, 2024
@TomWoodward
Copy link
Member

lets not forget to remove the image from the layout snippet, we didn't end up using it

snippets/models.py Outdated Show resolved Hide resolved
pages/models.py Outdated Show resolved Hide resolved
@mwvolo mwvolo requested a review from TomWoodward July 23, 2024 21:40
@@ -195,6 +195,8 @@ def page_by_slug(self, page_slug):
return Supporters.objects.all()
if page_slug == 'openstax-homepage':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this section be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if we want this to work before deployment of FE part 2.

This should be removed as part of the migration of the home page to the top level of the content root.

pages/models.py Show resolved Hide resolved
@mwvolo mwvolo merged commit cd1178f into main Jul 25, 2024
1 check failed
@mwvolo mwvolo deleted the customizable-pages branch July 25, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants