-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New RootPage and FlexPage types to support new homepage (and more) #1567
Conversation
02c3499
to
973220e
Compare
also, every link we have should always have |
@TomWoodward should any of those be required? Like the aria_label? |
aria-label for links can be optional, its just commonly needed when like 7 links on the page's text are "read more" |
lets not forget to remove the image from the layout snippet, we didn't end up using it |
@@ -195,6 +195,8 @@ def page_by_slug(self, page_slug): | |||
return Supporters.objects.all() | |||
if page_slug == 'openstax-homepage': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this section be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not if we want this to work before deployment of FE part 2.
This should be removed as part of the migration of the home page to the top level of the content root.
No description provided.