Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload ty notes to sf #1602

Merged
merged 17 commits into from
Jan 10, 2025
Merged

Upload ty notes to sf #1602

merged 17 commits into from
Jan 10, 2025

Conversation

mwvolo
Copy link
Member

@mwvolo mwvolo commented Jan 6, 2025

https://openstax.atlassian.net/browse/DATA-154
We have a ton of Thank You notes generated in the CMS, these might help us indicate usage at a school we don't know about.
This adds a salesforce_id to the record and uploads them, setting the id along the way.

The school sync also seemed to contain fields we no longer have on the account object in Salesforce, so updating those as well.

Copy link
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but Devynn's approval will mean more than mine.

@mwvolo
Copy link
Member Author

mwvolo commented Jan 9, 2025

@dmoreno27 can you make sure the thank you note script looks good to you? (most important change)
We did test on dev/sandbox, so I have faith - but let me know if you see anything that stands out.
If all looks good, you can just approve the PR.

@mwvolo mwvolo merged commit 7f02640 into main Jan 10, 2025
2 checks passed
@mwvolo mwvolo deleted the upload-ty-notes-to-sf branch January 10, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants