Skip to content

Commit

Permalink
Code review items
Browse files Browse the repository at this point in the history
  • Loading branch information
RoyEJohnson committed Aug 12, 2024
1 parent e781749 commit 86fa6f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/app/pages/details/common/links-to-translations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ function AnotherLanguage({
// translation is guaranteed to have a valid value, because the locale
// is pulled from translations
return (
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
<a href={`/details/books/${translation!.slug}`}>
<a href={`/details/books/${translation?.slug}`}>
<LanguageText locale={locale} />
</a>
);
Expand Down
2 changes: 1 addition & 1 deletion test/src/pages/details/book-details-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function BookDetailsWithContext({data, children}) {
}

export default function BookDetailsLoader({slug, children}) {
const absoluteSlug = slug.startsWith('/') ? slug : `/${slug}`;
const absoluteSlug = `/${slug}`;

return (
<MemoryRouter initialEntries={[absoluteSlug]}>
Expand Down

0 comments on commit 86fa6f7

Please sign in to comment.