Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old homepage #2645

Merged
merged 3 commits into from
Aug 13, 2024
Merged

remove old homepage #2645

merged 3 commits into from
Aug 13, 2024

Conversation

TomWoodward
Copy link
Member

@TomWoodward TomWoodward commented Jul 24, 2024

DISCO-435
the way the router works, if the old homepage (which was defined in the ui as home) is removed, it'll then search for a page with the slug home, and render it normally.

so to publish the new homepage all we have to do is make sure its slug is home and delete the previous code

@TomWoodward
Copy link
Member Author

do not merge until qa is done for previous deployment (we need to deploy the flex page editor and create the new page before we deploy this to use it as the homepage)

@mwvolo
Copy link
Member

mwvolo commented Jul 24, 2024

@TomWoodward can this be deployed to dev for testing social metadata stuff (I'd feel more confident removing the slug for openstax-homepage in the CMS code if so)? Or do we want to wait on that?

@TomWoodward
Copy link
Member Author

i think brittany wanted to qa on dev what will be in the first release, so we probably want to wait on that

@TomWoodward TomWoodward merged commit 09cb0b9 into main Aug 13, 2024
1 check passed
@TomWoodward TomWoodward deleted the remove-old-home branch August 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants