-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix postMessage in embedded Contact form #2673
Conversation
9f2a21f
to
74925e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small CSS concerns.
src/app/pages/contact/embedded.js
Outdated
<h1>Report an issue</h1> | ||
<div> | ||
Need to suggest a content correction instead? Fill out the{' '} | ||
<a href="/errata" target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the errata page with no book in the URL. With a book, the header gets populated and the selectors at the top are pushed down. Without a book, the page is useless.
https://openstax.org/errata/?book=Principles%20of%20Accounting%2C%20Volume%201%3A%20Financial%20Accounting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the book info inside this form to make the right url? Otherwise it seems like we should remove the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! I just plugged that link in there and never thought about it.
I've updated the paragraph to direct them to the Subjects page. It's a bit cumbersome for them, but I don't think we can reliably send the book title (which is what the errata form needs).
@@ -0,0 +1,30 @@ | |||
@import 'pattern-library/core/pattern-library/headers'; | |||
|
|||
.embedded-contact { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the put-away as a back button in a footer (like the design).
PR for that is:
https://github.com/openstax/assignments/pull/192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CORE-532]
Add thank you
6c131f4
to
d9697b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good, just have a question about the errata url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CORE-532
This makes the embedded Contact form (mostly) like the designs.