Port specific subjects page to ts #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
port-specific-subjects-page-to-ts
branch
from
734d835 to
8fba0ee
Compare
RoyEJohnson
force-pushed
the
port-specific-subjects-page-to-ts
branch
2 times, most recently
from
52476eb to
1df9afd
Compare
RoyEJohnson
commented
Oct 30, 2024
| @@ -41,7 +41,8 @@ function HoverText({which, thing}) { | |||
| export default function Carousel({ | |||
| atATime = 1, | |||
| children, | |||
| hoverTextThing | |||
| hoverTextThing, | |||
| ref | |||
There was a problem hiding this comment.
Bug fix: had been passing a ref to this, but not using it.
RoyEJohnson
force-pushed
the
port-specific-subjects-page-to-ts
branch
from
1df9afd to
516fc13
Compare
jivey
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-537
This is based on #2674, which should be merged before reviewing this. Update: that is done.
Overwhelmingly, this is just adding types and making them work, then writing tests for the code.
In some files, I did some rearranging of code blocks, and reviewing might be best looking at old file and new file side-by-side in separate windows rather than the changes.