fix relation membership list using a non-deterministic order #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
approved these changes
Jan 3, 2025
1ec5
reviewed
Jan 3, 2025
k-yle
force-pushed
the
kh/membership-order
branch
4 times, most recently
from
7729c1e to
0867cf0
Compare
1ec5
reviewed
Jan 7, 2025
k-yle
force-pushed
the
kh/membership-order
branch
from
0867cf0 to
ff8f044
Compare
1ec5
approved these changes
Jan 8, 2025
tyrasd
requested changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a way, the list of relations uses an unpredictable order.
This is annoying, but more importantly, it causes a rare bug: You can't merge ways if the relations were added in a different order.
For example, merging these ways:..
...will cause an unexpected error: