Tirex-Backend-Manager should fail to start if a mapnik style cannot be loaded. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemd list exit code 2 as “Invalid or excess arguments.” <https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#:~:text=exit_invalidargument>
If there is a problem initializing a map style, this patch will cause the mapnik backend to exit (with 2). This causes the complete tirex-backend-manager process to exit with 2. The previous behaviour was for it to constantly attempt to initialize the map forevery A mapnik style can fail to load for many reasons, such as missing database tables. This change means incorrectly set up servers can be detected quicker.
…caused by bad config) Currently systemd will constantly try to restart tirex-backend-manager if it fails, forever and every. This change makes systemd not try to restart iff tirex-backend-manager exits with exit status 2. Exit 2 can happen in the last commit.
|
I've done some (but not a lot) of real world testing of this patch. I'd appreciate feedback from others about the code. I am not very good at C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a problem initializing a map style, this patch will cause
the mapnik backend to exit (with 2). This causes the complete
tirex-backend-manager process to exit with 2. The previous behaviour was
for it to constantly attempt to initialize the map forevery
A mapnik style can fail to load for many reasons, such as missing
database tables. This change means incorrectly set up servers can be
detected quicker.