Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react 18 #864

Closed
wants to merge 6 commits into from
Closed

feat: react 18 #864

wants to merge 6 commits into from

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Apr 18, 2022

Types

  • 🪚 Refactors

Background or solution

this close: #861

Changelog

@bytemain bytemain added this to the 2.18 milestone Apr 24, 2022
@Aaaaash Aaaaash changed the title wip: feat: react 18 feat: react 18 Apr 26, 2022
@Aaaaash Aaaaash force-pushed the feat/react-18-wip branch 2 times, most recently from 0f4e951 to 7e414de Compare April 26, 2022 08:36
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #864 (e7b9854) into main (3340fa8) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   58.48%   58.44%   -0.04%     
==========================================
  Files        1220     1220              
  Lines       75099    75102       +3     
  Branches    15616    15619       +3     
==========================================
- Hits        43923    43896      -27     
- Misses      28416    28443      +27     
- Partials     2760     2763       +3     
Impacted Files Coverage Δ
...xt/src/browser/services/file-tree-model.service.ts 51.33% <0.00%> (ø)
packages/core-browser/src/layout/index.ts 58.02% <50.00%> (-1.98%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 60.06% <50.00%> (-0.07%) ⬇️
...kages/editor/src/browser/format/formatterSelect.ts 78.78% <100.00%> (ø)
...es/file-tree-next/src/browser/file-tree.service.ts 61.90% <100.00%> (ø)
...s/main-layout/src/browser/tabbar/tabbar.service.ts 61.55% <100.00%> (-0.54%) ⬇️
packages/output/src/browser/output.service.ts 63.07% <100.00%> (ø)
...ages/comments/src/browser/comments-zone.service.ts 66.66% <0.00%> (-33.34%) ⬇️
.../comments/src/browser/comments-feature.registry.ts 60.00% <0.00%> (-11.43%) ⬇️
...owser/src/components/layout/split-panel.service.ts 45.16% <0.00%> (-6.46%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3340fa8...e7b9854. Read the comment docs.

@Aaaaash Aaaaash force-pushed the feat/react-18-wip branch from f718208 to aa654e2 Compare April 27, 2022 13:49
@Aaaaash Aaaaash force-pushed the feat/react-18-wip branch from aa654e2 to 7e6cbbf Compare April 27, 2022 13:51
@Aaaaash Aaaaash closed this May 5, 2022
@Aaaaash Aaaaash deleted the feat/react-18-wip branch May 5, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] 升级到 React 18
2 participants