Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react 18 #970

Closed
wants to merge 4 commits into from
Closed

feat: react 18 #970

wants to merge 4 commits into from

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented May 7, 2022

Types

  • 🎉 New Features

Background or solution

Changelog

@Aaaaash
Copy link
Member Author

Aaaaash commented May 7, 2022

/publish

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

🎉 Pre-Release version 2.17.3-next-1651908670.0 publish successful! You can install prerelease version via npm install [email protected] @Aaaaash

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #970 (706e10f) into main (652fcf6) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   57.86%   57.82%   -0.05%     
==========================================
  Files        1247     1247              
  Lines       77667    77670       +3     
  Branches    16195    16198       +3     
==========================================
- Hits        44945    44909      -36     
- Misses      29804    29837      +33     
- Partials     2918     2924       +6     
Flag Coverage Δ
jsdom 52.49% <50.00%> (-0.07%) ⬇️
node 15.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xt/src/browser/services/file-tree-model.service.ts 51.96% <0.00%> (ø)
packages/core-browser/src/layout/index.ts 58.02% <50.00%> (-1.98%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 60.38% <50.00%> (-4.89%) ⬇️
...es/file-tree-next/src/browser/file-tree.service.ts 68.55% <100.00%> (ø)
...s/main-layout/src/browser/tabbar/tabbar.service.ts 61.78% <100.00%> (-3.53%) ⬇️
packages/output/src/browser/output.service.ts 63.07% <100.00%> (ø)
...owser/src/components/layout/split-panel.service.ts 45.16% <0.00%> (-6.46%) ⬇️
packages/core-browser/src/layout/layout-state.ts 63.79% <0.00%> (-3.45%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652fcf6...706e10f. Read the comment docs.

@Aaaaash Aaaaash force-pushed the refactor/upgrade-react-18 branch from 0433079 to 0fa5471 Compare May 10, 2022 03:48
@bytemain
Copy link
Member

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.17.3-next-1652155566.0 publish successful! You can install prerelease version via npm install [email protected] @bytemain

@Aaaaash Aaaaash force-pushed the refactor/upgrade-react-18 branch from 0fa5471 to 4887baf Compare May 13, 2022 02:06
@erha19 erha19 added this to the 2.19 milestone May 18, 2022
@Aaaaash Aaaaash force-pushed the refactor/upgrade-react-18 branch from 4887baf to f698533 Compare May 30, 2022 09:37
@erha19 erha19 mentioned this pull request May 31, 2022
15 tasks
@erha19
Copy link
Member

erha19 commented Jun 24, 2022

@Aaaaash Browser Test 挂了

image

@erha19
Copy link
Member

erha19 commented Jun 29, 2022

@Aaaaash 这里的升级会不会对旧插件的使用带来影响?例如需要基于 React18 重新构建一下?

@Aaaaash
Copy link
Member Author

Aaaaash commented Jun 29, 2022

@Aaaaash 这里的升级会不会对旧插件的使用带来影响?例如需要基于 React18 重新构建一下?

理论上来说不需要

@Aaaaash Aaaaash force-pushed the refactor/upgrade-react-18 branch from f698533 to cd1a6b6 Compare June 29, 2022 03:24
@erha19
Copy link
Member

erha19 commented Jul 4, 2022

/publish

1 similar comment
@bytemain
Copy link
Member

bytemain commented Jul 8, 2022

/publish

@erha19 erha19 modified the milestones: 2.19, 2.20 Jul 8, 2022
@Ricbet
Copy link
Member

Ricbet commented Jul 14, 2022

/publish

@Aaaaash Aaaaash force-pushed the refactor/upgrade-react-18 branch from 022385b to 706e10f Compare July 14, 2022 09:33
@Ricbet
Copy link
Member

Ricbet commented Jul 14, 2022

/publish

@github-actions
Copy link
Contributor

🎉 PR Next version 2.18.11-next-1657791786.0 publish successful! You can install prerelease version via npm install [email protected] @Ricbet

2.18.11-next-1657791786.0

@Aaaaash Aaaaash closed this Jul 15, 2022
@erha19 erha19 mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants