Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Upgrade opentelemetry to version 0.5.0 #6

Closed
GDegrove opened this issue Dec 9, 2020 · 7 comments
Closed

Upgrade opentelemetry to version 0.5.0 #6

GDegrove opened this issue Dec 9, 2020 · 7 comments

Comments

@GDegrove
Copy link
Contributor

GDegrove commented Dec 9, 2020

When trying to run both opentelemetry_ecto and opentelemetry_phoenix in an application, we get a dependencies error:

Failed to use "opentelemetry" (version 0.5.0) because
  apps/common/mix.exs requires ~> 0.5.0
  opentelemetry_ecto (version 0.1.0) requires ~> 0.4.0
  opentelemetry_phoenix (version 0.2.0) requires ~> 0.5.0

In order to use both, and have this issue, is it possible to update the open_telemetry dependencies to version 0.5.0

@jinjagit
Copy link

This would be great. We are using opentelemetry_phoenix and encountered the same dependency error when trying to add this dependency.

@jinjagit jinjagit mentioned this issue Mar 18, 2021
@sgerrand
Copy link

sgerrand commented Apr 6, 2021

👋 @tsloughter, are you able to assist with this request? It would help me out a lot as well.

@sgerrand
Copy link

sgerrand commented Apr 6, 2021

To be clear, @GDegrove contributed the changes (❤️) in #7 and they're merged. What I'm really interested in is a new version of this module to be published to Hex, which is what @garthk asked for in #9.

@tsloughter
Copy link
Contributor

When #12 is updated to 1.0.0-rc.1 I'll merge it and a release can be published.

@bryannaegele
Copy link
Contributor

@GDegrove we're going to migrate this repo to https://github.com/open-telemetry/opentelemetry-erlang-contrib soon. Can you please sign the CNCF CLA so we can proceed?

https://identity.linuxfoundation.org/projects/cncf

Thank you!

@GDegrove
Copy link
Contributor Author

Hello,
I totally forgot to continue the process once started, the process is ongoing,

Regards,
Gil

@GDegrove
Copy link
Contributor Author

@bryannaegele I think it's all set.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants