Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Update opentelemetry 0.5.0 #7

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Update opentelemetry 0.5.0 #7

merged 1 commit into from
Dec 25, 2020

Conversation

GDegrove
Copy link
Contributor

@GDegrove GDegrove commented Dec 9, 2020 •
edited
Loading

Update dependencies to opentelemetry version 0.5.0 in order to be able to integrate with opentelemetry_phoenix.

In order to do it I had to:

  • change reference of configuration from ot_ to otel_
  • Change the way a span is stopped by calling Span.end_span(span)

@GDegrove GDegrove force-pushed the update_opentelemetry_0.5.0 branch 3 times, most recently from 278b731 to fc7cfb2 Compare December 9, 2020 10:02
@GDegrove GDegrove force-pushed the update_opentelemetry_0.5.0 branch from fc7cfb2 to 462a1e1 Compare December 9, 2020 12:46
@luizmiranda7
Copy link

@bryannaegele and @tsloughter, my company is using this PR branch for one of our core services. Based on that I'd like to endorse the approve.

@tsloughter
Copy link
Contributor

Thanks @luizmiranda7 and @GDegrove. Turns out I wasn't watching this repo so only saw this PR once I was mentioned :)

@tsloughter tsloughter merged commit 149ab36 into opentelemetry-beam:master Dec 25, 2020
@sgerrand sgerrand mentioned this pull request Apr 6, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luizmiranda7 luizmiranda7 luizmiranda7 approved these changes

@tsloughter tsloughter tsloughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GDegrove @luizmiranda7 @tsloughter