Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration dendrite test fixes #1029

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Conversation

Eugene-hu
Copy link
Contributor

Parallel testing in circle ci leads to a flaky test in the dendrite. This PR fixes the issue along with an issue in the speed. The test was improperly pulling data when it was not supposed to.

@Eugene-hu Eugene-hu requested a review from eduardogr December 13, 2022 20:36
@Eugene-hu Eugene-hu changed the base branch from master to nobunaga December 13, 2022 20:36
Copy link
Contributor

@eduardogr eduardogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @Eugene-hu !! Thanks for this!

@Eugene-hu Eugene-hu merged commit af27135 into nobunaga Dec 13, 2022
@Eugene-hu Eugene-hu deleted the flaky_test_dendrite_fixes branch December 13, 2022 22:00
opentaco added a commit that referenced this pull request Dec 21, 2022
…tness

* V3.6.0 nobunaga merge (#1028)

* Integration dendrite test fixes (#1029)

* Adding 3.6.0 release notes to CHANGELOG

* Merge pull request #1032 from opentensor/sre/adding-3.6.0-changelog

* [BIT-612] Validator robustness improvements (#1034)

* Update version to 3.6.1

Co-authored-by: Eugene-hu <[email protected]>
Co-authored-by: opentaco <[email protected]>
Co-authored-by: opentaco <[email protected]>
Co-authored-by: isabella618033 <[email protected]>
Co-authored-by: Eduardo <[email protected]>
Co-authored-by: Eduardo García <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants