Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7 version checking #1195

Merged
merged 14 commits into from
Mar 21, 2023
Merged

3.7 version checking #1195

Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d0fdc57
fix metagraph network name issue
camfairchild Mar 21, 2023
cb95171
fix local entrypoint port
camfairchild Mar 21, 2023
fa2e7fe
pin scalecode to 1.2.0
camfairchild Mar 21, 2023
647c816
pin jsonschema format-nongpl
camfairchild Mar 21, 2023
5538760
fix delegates_json
camfairchild Mar 21, 2023
2c71c90
get right dir
camfairchild Mar 21, 2023
c89c2fc
Merge branch 'release/3.7.0' into hotfixes-3.7.0
camfairchild Mar 21, 2023
a90f781
remove extra get delegated
camfairchild Mar 21, 2023
d914afc
use lite sync for metagraph by default
camfairchild Mar 21, 2023
51b2a02
fix blockhash for rpcs
camfairchild Mar 21, 2023
492a359
use lite in sync()
camfairchild Mar 21, 2023
fd9d299
Merge remote-tracking branch 'origin/release/3.7.0' into hotfixes-3.7.0
Eugene-hu Mar 21, 2023
bbc9606
version checking
Eugene-hu Mar 21, 2023
ae51066
int comparison + default checks
Eugene-hu Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bittensor/_axon/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,12 @@ def parse_signature(
) -> Tuple[int, str, str, str, int]:
r"""Attempts to parse a signature from the metadata"""
signature = metadata.get("bittensor-signature")
version = metadata.get('bittensor-version')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata is a Dict[str, str]. You need to cast to integer if you want to compare it with an integer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adrian!

if signature is None:
raise Exception("Request signature missing")
if version < 370:
raise Exception("Incorrect Version")

for parser in [self.parse_signature_v2, self.parse_legacy_signature]:
parts = parser(signature)
if parts is not None:
Expand Down