Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cicleci check for requirements python version support #1480

Closed
wants to merge 3 commits into from
Closed

add cicleci check for requirements python version support #1480

wants to merge 3 commits into from

Conversation

ifrit98
Copy link
Contributor

@ifrit98 ifrit98 commented Aug 10, 2023

Does 2 thins:

  • Adds a bash script to verify that all python requirements are supported with the given our officially supported python versions. (e.g. 38, 39, 310, 311)
  • Adds a circle CI job so that if any of the tests fail from the bash script, the job fails.

@ifrit98 ifrit98 requested a review from eduardogr August 10, 2023 16:27
@ifrit98 ifrit98 requested a review from camfairchild August 10, 2023 16:38
@ifrit98 ifrit98 changed the base branch from new_staging to revolution August 10, 2023 16:39
@ifrit98 ifrit98 changed the base branch from revolution to new_staging August 10, 2023 16:39
eduardogr
eduardogr reviewed Aug 10, 2023
View reviewed changes
.circleci/config.yml
Comment on lines +53 to +55
- run:
name: Make script executable
command: chmod +x ./scripts/check_compatibility.sh
Copy link
Contributor

@eduardogr eduardogr Aug 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is enough adding the permissions in the repository itself, can you try it?

If that is the case we can avoid this step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edu! Ended up resolving these in: #1483

@ifrit98
Copy link
Contributor Author

ifrit98 commented Aug 16, 2023

Migrating to: #1483

@ifrit98 ifrit98 closed this Aug 16, 2023
@ifrit98 ifrit98 deleted the req_compat branch November 30, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardogr eduardogr eduardogr left review comments

@camfairchild camfairchild Awaiting requested review from camfairchild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifrit98 @eduardogr