CI: Flake8

.circleci/config.yml

@@ -152,6 +152,51 @@ jobs:
                   #CI_JOB_ID: $CIRCLE_NODE_INDEX
                   #COVERALLS_PARALLEL: true
 
+  lint-and-type-check:
+    resource_class: medium
+    parallelism: 2
+    parameters:
+      python-version:
+        type: string
+    docker:
+      - image: cimg/python:<< parameters.python-version >>
+
+    steps:
+      - checkout
+
+      - restore_cache:
+          name: Restore cached venv
+          keys:
+            - v2-pypi-py<< parameters.python-version >>-{{ checksum "requirements/prod.txt" }}+{{ checksum "requirements/dev.txt" }}
+            - v2-pypi-py<< parameters.python-version >>
+
+      - run:
+          name: Update & Activate venv
+          command: |
+            python -m venv env/
+            . env/bin/activate
+            python -m pip install --upgrade pip
+            python -m pip install '.[dev]'
+            pip install flake8
+
+      - save_cache:
+          name: Save cached venv
+          paths:
+            - "env/"
+          key: v2-pypi-py<< parameters.python-version >>-{{ checksum "requirements/prod.txt" }}+{{ checksum "requirements/dev.txt" }}
+
+      - run:
+          name: Install Bittensor
+          command: |
+            . env/bin/activate
+            pip install -e '.[dev]'
+
+      - run:
+          name: Lint with flake8
+          command: |
+            . env/bin/activate
+            python -m flake8 bittensor/ --count
+
   unit-tests-all-python-versions:
     docker:
       - image: cimg/python:3.10
@@ -251,6 +296,12 @@ workflows:
       - unit-tests-all-python-versions:
           requires:
             - build-and-test
+      - lint-and-type-check:
+          matrix:
+            parameters:
+              python-version: ["3.8.12", "3.9.13", "3.10.6"]
+          requires:
+            - build-and-test
       #- coveralls:
           #requires:
             #- build-and-test

.flake8

@@ -0,0 +1,4 @@
+[flake8]
+max-line-length = 120
+exclude = .git,__pycache__, __init__.py, docs/source/conf.py,old,build,dist,venv,.venv,.tox
+select = E9,F63,F7,F82,F401

bittensor/axon.py

@@ -25,7 +25,6 @@
 import copy
 import json
 import time
-import base64
 import asyncio
 import inspect
 import uvicorn
@@ -39,11 +38,10 @@
 from fastapi.responses import JSONResponse
 from substrateinterface import Keypair
 from fastapi import FastAPI, APIRouter, Request, Response, Depends
-from starlette.types import Scope, Message
 from starlette.responses import Response
 from starlette.requests import Request
 from starlette.middleware.base import BaseHTTPMiddleware, RequestResponseEndpoint
-from typing import Dict, Optional, Tuple, Union, List, Callable, Any
+from typing import Optional, Tuple, Callable, Any
 
 from bittensor.errors import (
     InvalidRequestNameError,
@@ -647,7 +645,7 @@ def add_args(cls, parser: argparse.ArgumentParser, prefix: str = None):
             parser.add_argument(
                 "--" + prefix_str + "axon.max_workers",
                 type=int,
-                help="""The maximum number connection handler threads working simultaneously on this endpoint. 
+                help="""The maximum number connection handler threads working simultaneously on this endpoint.
                         The grpc server distributes new worker threads to service requests up to this number.""",
                 default=default_axon_max_workers,
             )

bittensor/chain_data.py

@@ -270,7 +270,7 @@ def to_parameter_dict(self) -> "torch.nn.ParameterDict":
     @classmethod
     def from_parameter_dict(
         cls, parameter_dict: "torch.nn.ParameterDict"
-    ) -> "axon_info":
+    ) -> "AxonInfo":
         r"""Returns an axon_info object from a torch parameter_dict."""
         return cls(**dict(parameter_dict))
 

bittensor/commands/identity.py

@@ -1,5 +1,4 @@
 import argparse
-from rich import print
 from rich.table import Table
 from rich.prompt import Prompt
 from sys import getsizeof

bittensor/commands/inspect.py

@@ -15,18 +15,15 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-import json
 import argparse
 import bittensor
 from tqdm import tqdm
 from rich.table import Table
 from rich.prompt import Prompt
 from .utils import (
-    check_netuid_set,
     get_delegates_details,
     DelegatesDetails,
     get_hotkey_wallets_for_wallet,
-    get_coldkey_wallets_for_path,
     get_all_wallets_for_path,
     filter_netuids_by_registered_hotkeys,
 )

bittensor/commands/metagraph.py

@@ -17,7 +17,6 @@
 
 import argparse
 import bittensor
-from rich.prompt import Prompt
 from rich.table import Table
 from .utils import check_netuid_set
 

bittensor/commands/misc.py

@@ -16,10 +16,8 @@
 # DEALINGS IN THE SOFTWARE.
 
 import os
-import sys
 import argparse
 import bittensor
-from typing import List
 from rich.prompt import Prompt
 from rich.table import Table
 

bittensor/commands/network.py

@@ -15,7 +15,6 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-import time
 import argparse
 import bittensor
 from . import defaults

bittensor/commands/root.py

@@ -15,15 +15,14 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-import sys
 import re
 import torch
 import typing
 import argparse
 import numpy as np
 import bittensor
 from typing import List, Optional, Dict
-from rich.prompt import Prompt, Confirm
+from rich.prompt import Prompt
 from rich.table import Table
 from .utils import get_delegates_details, DelegatesDetails
 

bittensor/commands/senate.py

@@ -15,13 +15,12 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-import sys
+
 import argparse
 import bittensor
 from rich.prompt import Prompt, Confirm
 from rich.table import Table
-from rich.console import Console
-from typing import List, Union, Optional, Dict, Tuple
+from typing import Optional, Dict
 from .utils import get_delegates_details, DelegatesDetails
 from . import defaults
 

bittensor/commands/stake.py

@@ -292,15 +292,13 @@ def add_args(cls, parser: argparse.ArgumentParser):
 
 
 ### Stake list.
-import json
 import argparse
 import bittensor
 from tqdm import tqdm
 from rich.table import Table
 from rich.prompt import Prompt
 from typing import Dict, Union, List, Tuple
-from concurrent.futures import ThreadPoolExecutor
-from .utils import check_netuid_set, get_delegates_details, DelegatesDetails
+from .utils import get_delegates_details, DelegatesDetails
 from . import defaults
 
 console = bittensor.__console__

bittensor/commands/utils.py

@@ -20,7 +20,7 @@
 import torch
 import bittensor
 from typing import List, Dict, Any, Optional
-from rich.prompt import Confirm, Prompt, PromptBase
+from rich.prompt import Confirm, PromptBase
 import requests
 from dataclasses import dataclass
 from . import defaults

bittensor/dendrite.py

@@ -402,7 +402,7 @@ async def forward(
 
         async def query_all_axons(
             is_stream: bool,
-        ) -> Union[AsyncGenerator[Any], bittenst.Synapse, bittensor.StreamingSynapse]:
+        ) -> Union[AsyncGenerator[Any], bittensor.Synapse, bittensor.StreamingSynapse]:
             """
             Handles the processing of requests to all targeted axons, accommodating both streaming and non-streaming responses.
 
@@ -423,7 +423,7 @@ async def query_all_axons(
             async def single_axon_response(
                 target_axon,
             ) -> Union[
-                AsyncGenerator[Any], bittenst.Synapse, bittensor.StreamingSynapse
+                AsyncGenerator[Any], bittensor.Synapse, bittensor.StreamingSynapse
             ]:
                 """
                 Manages the request and response process for a single axon, supporting both streaming and non-streaming modes.

bittensor/extrinsics/delegation.py

@@ -19,9 +19,8 @@
 import bittensor
 from ..errors import *
 from rich.prompt import Confirm
-from typing import List, Dict, Union, Optional
+from typing import Union, Optional
 from bittensor.utils.balance import Balance
-from .staking import __do_add_stake_single
 
 from loguru import logger
 

bittensor/extrinsics/network.py

@@ -15,11 +15,9 @@
 # THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
-import json
 import time
 import bittensor
-import bittensor.utils.networking as net
-from dataclasses import asdict
+
 from rich.prompt import Confirm
 
 

bittensor/extrinsics/prometheus.py

@@ -18,7 +18,6 @@
 import bittensor
 
 import json
-from rich.prompt import Confirm
 import bittensor.utils.networking as net
 
 
@@ -75,7 +74,7 @@ def prometheus_extrinsic(
     else:
         external_ip = ip
 
-    call_params: "PrometheusServeCallParams" = {
+    call_params: "bittensor.PrometheusServeCallParams" = {
         "version": bittensor.__version_as_int__,
         "ip": net.ip_to_int(external_ip),
         "port": port,

bittensor/extrinsics/root.py

@@ -21,7 +21,7 @@
 import time
 import torch
 from rich.prompt import Confirm
-from typing import Union, List
+from typing import Union
 import bittensor.utils.weight_utils as weight_utils
 
 from loguru import logger

bittensor/extrinsics/senate.py

@@ -21,7 +21,6 @@
 
 import time
 from rich.prompt import Confirm
-from ..errors import *
 
 
 def register_senate_extrinsic(

bittensor/extrinsics/serving.py

@@ -17,7 +17,6 @@
 # DEALINGS IN THE SOFTWARE.
 import json
 import bittensor
-from dataclasses import asdict
 import bittensor.utils.networking as net
 from rich.prompt import Confirm
 from ..errors import MetadataError
@@ -65,7 +64,7 @@ def serve_extrinsic(
     """
     # Decrypt hotkey
     wallet.hotkey
-    params: "AxonServeCallParams" = {
+    params: "bittensor.AxonServeCallParams" = {
         "version": bittensor.__version_as_int__,
         "ip": net.ip_to_int(ip),
         "port": port,

bittensor/extrinsics/staking.py

@@ -19,7 +19,7 @@
 import bittensor
 from rich.prompt import Confirm
 from time import sleep
-from typing import List, Dict, Union, Optional
+from typing import List, Union, Optional
 from bittensor.utils.balance import Balance
 
 

bittensor/extrinsics/transfer.py

@@ -19,7 +19,7 @@
 import bittensor
 
 from rich.prompt import Confirm
-from typing import List, Dict, Union
+from typing import Union
 from ..utils.balance import Balance
 from ..utils import is_valid_bittensor_address_or_public_key
 

bittensor/extrinsics/unstaking.py

@@ -19,7 +19,7 @@
 import bittensor
 from rich.prompt import Confirm
 from time import sleep
-from typing import List, Dict, Union, Optional
+from typing import List, Union, Optional
 from bittensor.utils.balance import Balance
 
 

bittensor/stream.py

@@ -3,7 +3,7 @@
 from starlette.responses import StreamingResponse as _StreamingResponse
 from starlette.responses import Response
 from starlette.types import Send, Receive, Scope
-from typing import Callable, Awaitable, List
+from typing import Callable, Awaitable
 from pydantic import BaseModel
 from abc import ABC, abstractmethod
 

bittensor/subtensor.py

@@ -41,7 +41,6 @@
     NeuronInfoLite,
     AxonInfo,
     ProposalVoteData,
-    ProposalCallData,
     IPInfo,
     custom_rpc_type_registry,
 )
@@ -65,7 +64,7 @@
     swap_hotkey_extrinsic,
 )
 from .extrinsics.transfer import transfer_extrinsic
-from .extrinsics.set_weights import set_weights_extrinsic, ttl_set_weights_extrinsic
+from .extrinsics.set_weights import ttl_set_weights_extrinsic
 from .extrinsics.prometheus import prometheus_extrinsic
 from .extrinsics.delegation import (
     delegate_extrinsic,

bittensor/synapse.py

@@ -16,13 +16,11 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 # DEALINGS IN THE SOFTWARE.
 
-import ast
-import sys
-import torch
-import json
+
 import base64
-import typing
-import hashlib
+import json
+import sys
+
 import pydantic
 from pydantic.schema import schema
 import bittensor
@@ -625,9 +623,6 @@ def to_headers(self) -> dict:
             }
         )
 
-        # Getting the type hints for the properties of the instance
-        property_type_hints = typing.get_type_hints(self)
-
         # Getting the fields of the instance
         instance_fields = self.dict()