Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, adds stake and other methods #2622

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Feb 3, 2025

Updates (on AsyncSubtensor and Subtensor):

  • get_stake: netuid is now required, cleans up the logic
  • get_stake_for_coldkey_and_hotkey: no longer an alias for get_stake, but rather allows for getting StakeInfo objects from one or more netuids. (resolves Issue get_stake_for_coldkey_hotkey has misordered args #2568)
  • get_transfer_fee: Now looks for "partial_fee" rather than "partialFee", as this is what we get from Subtensor
  • Tests affecting these above
  • get_block_hash: adds return type hint
  • Removes ScaleType from type hints, replaced with correct type hints.
  • Improves the Certificate type by building in decoding to str from the dict.

@thewhaleking thewhaleking requested review from camfairchild and a team February 3, 2025 15:46
@thewhaleking thewhaleking linked an issue Feb 3, 2025 that may be closed by this pull request
@thewhaleking thewhaleking marked this pull request as draft February 3, 2025 16:34
@thewhaleking thewhaleking marked this pull request as ready for review February 3, 2025 16:50
@thewhaleking thewhaleking marked this pull request as draft February 3, 2025 16:51
@thewhaleking thewhaleking marked this pull request as ready for review February 3, 2025 22:16
@thewhaleking thewhaleking changed the title Deprecates get_stake_for_coldkey_and_hotkey Adds get_stake_for_coldkey_and_hotkey method Feb 3, 2025
@thewhaleking thewhaleking changed the title Adds get_stake_for_coldkey_and_hotkey method Fixes, adds methods Feb 4, 2025
@thewhaleking thewhaleking changed the title Fixes, adds methods Fixes, adds stake methods Feb 4, 2025
@thewhaleking thewhaleking changed the title Fixes, adds stake methods Fixes, adds stake and other methods Feb 4, 2025
@thewhaleking thewhaleking merged commit 491dcb1 into staging-pre-merge-new-async Feb 4, 2025
15 checks passed
@thewhaleking thewhaleking deleted the async/thewhaleking/deprecate-get_stake_for_coldkey_and_hotkey branch February 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_stake_for_coldkey_hotkey has misordered args
2 participants