Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] use with env to reset start method after #935

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

camfairchild
Copy link
Collaborator

@camfairchild camfairchild commented Sep 30, 2022

This PR changes the set start method to force to avoid errors on reregister
This PR also puts the set start method logic into a with-context in-case other parts of the process set the start method during execution.

@camfairchild camfairchild requested a review from Eugene-hu October 1, 2022 00:22
@camfairchild camfairchild merged commit e7240ef into release/3.3.4 Oct 3, 2022
@camfairchild camfairchild deleted the fix/use_with_to_manage_start_method branch October 3, 2022 19:11
Eugene-hu added a commit that referenced this pull request Oct 3, 2022
* [feature] external axon flags (#887)

* add external axon changes

* add defaults for new axon flags

* fix args to axon

* default to internal ip and port if not specified

* add new args and todefaults

* add axon unit tests

* add description for subtensor integration test

* move test to unit test

* create new test file
add/update copyright notices

* don't default to internal ip

* add tests for setting the full_address

* add tests for subtensor.serve w/external axon info

* allow external port config to be None

* switch to mock instead of patch

* fix test mocks

* change mock config create

* fix/add default config

* change asserts add mesage

* fix check call args

* fix mock config set

* only call once

* fix help wording

* should be True

* [fix] fixes unstake with max-stake flag (#905)

* add equality to None to the balance class

* add tests for the None case

* local train bug fix (#906)

* [feature] [CUDA solver] Add multi-GPU and ask for CUDA during btcli run (#893)

* added cuda solver

* boost versions to fix pip error

* allow choosing device id

* fix solution check to use keccak

* adds params for cuda and dev_id to register

* list devices by name during selection

* add block number logging

* fix calculation of hashrate

* fix update interval default

* add --TPB arg to register

* add update_interval flag

* switch back to old looping/work structure

* change typing

* device count is a function

* stop early if wallet registered

* add update interval and num proc flag

* add better number output

* optimize multiproc cpu reg
keeping proc until solution

* fix test

* change import to cubit

* fix import and default

* up default
should have default in CLI call

* add comments about params

* fix config var access

* add cubit as extra

* handle stale pow differently
check registration after failure

* restrict number of processes for integration test

* fix stale check

* use wallet.is_registered instead

* attempt to fix test issue

* fix my test

* oops typo

* typo again ugh

* remove print out

* fix partly reg test

* fix if solution None

* fix test?

* fix patch

* add args for cuda to subtensor

* add cuda args to reregister call

* add to wallet register the cuda args

* fix refs and tests

* add for val test also

* fix tests with rereg

* fix patch for tests

* add mock_register to subtensor passed instead

* move register under the check for isregistered

* use patch obj instead

* fit patch object

* fix prompt

* remove unneeded if

* modify POW submit to use rolling submit again

* add backoff to block get from network

* add test for backoff get block

* suppress the dev id flag if not set

* remove dest so it uses first arg

* fix pow submit loop

* move registration status with

* fix max attempts check

* remove status in subtensor.register

* add submit status

* change to neuron get instead

* fix count

* try to patch live display

* fix patch

* .

* separate test cases

* add POWNotStale and tests

* add more test cases for block get with retry

* fix return to None

* fix arg order

* fix indent

* add test to verify solution is submitted

* fix mock call

* patch hex bytes instead

* typo :/

* fix print out for unstake

* fix indexing into mock call

* call indexing

* access dict not with dot

* fix other indent

* add CUDAException for cubit

* up cubit version

* [Feature] ask cuda during btcli run (#890)

* add ask for cuda reg config in btcli run

* suppress unset arg

* [Feature] [cuda solver] multi gpu (#891)

* change diff display out

* remove logging

* check cubit support in the check config

* allow 1 or more devices in flag

* cuda flag should be suppress

* modify how cpu count is found

* make a solver base class

* add a solverbase for CUDA

* use mutli process kernel launching, one per GPU

* move check under dot get accessor

* Feature/cuda solver multi gpu (#892)

* change diff display out

* remove logging

* check cubit support in the check config

* allow 1 or more devices in flag

* cuda flag should be suppress

* modify how cpu count is found

* make a solver base class

* add a solverbase for CUDA

* use mutli process kernel launching, one per GPU

* move check under dot get accessor

* add All gpus specification

* continue trying reg after Stale

* catch for OSX

* dont use qsize

* add test for continue after being stale

* patch get_nowait instead of qsize

* [Docs] Update old docs link to new link. Change discord invite to custom link (#915)

* Update old docs link to new one

This change deletes the old gitbooks documentation link and replaces it with the new one.

* fix discord links

Co-authored-by: Mac Thrasher <[email protected]>

* Fix for test_neuron.py (#917)

prevents downloading from huggingface

* [feature] add --seed option to regen_hotkey (#916)

* add seed option to regen hotkey

* make seed optional and fix docstring

* add tests for both coldkey and hotkey regen w/seed

* oops, make seed optional

* fix old test, add config.seed

* circle ci version update and fix (#920)

* Add test_phrases_split unit test

Asserts that randomly instantiated compact_topk encodings can be correctly decoded to recover the original topk_tensor.

* Update unravel_topk_token_phrases with faster implementation

Replaces .tensor_split() with block indexing to avoid extra copy operations.

* Rename test_phrases_split to test_random_topk_token_phrases

* Unit tests cleanup (#922)

* circle ci version update and fix

* Test clean up

* uncomment test and remove specific test

* remove loguru and fix flaky tests

* fix syncing

* removing tokenizer equivalence + some bug fixes

* moving old dataset test

* Deactivate test_random_topk_token_phrases unit test

* Create topk_tensor on origin device

* Normalization Update (#909)

* local train bug fix

* normalization update

* fix tests

* remove test

* updated normalization

* Naming changes, bug fixes

* subtensor update for max clip

* max weight to a million

* Fixes for ordering and comments

* additional tests

* string fix

* numerical stability and testing updates

* minor update for division by zero

* Naming and spacing fixes

* epsilon update

* small fix

* Adding development workflow documentation and script for bumping the version (#918)

BIT-582 Adding development workflow documentation and script for bumping the version

* Updated version 3.3.4

* Revert "Normalization Update (#909)"

This reverts commit 3990a28.

* version update

* memory fix to release (#932)

.

* use force on set_start_method

* [fix] Enable the stake blacklist (#931)

* uncomment stake blaclist

* add test for blacklisted stake

* [Fix] use with env to reset start method after (#935)

* use with env to reset start method after

* .

Co-authored-by: Cameron Fairchild <[email protected]>
Co-authored-by: Mac Thrasher <[email protected]>
Co-authored-by: opentaco <[email protected]>
Co-authored-by: opentaco <[email protected]>
Co-authored-by: Eduardo García <[email protected]>
Co-authored-by: isabella618033 <[email protected]>
Co-authored-by: Cameron Fairchild <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants