Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/no more weird runtime api encoding #1227

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

camfairchild
Copy link
Contributor

Description

This PR changes the runtime APIs to only use the actual types they are expecting, instead of encoding/decoding to Vec<u8>.
This means we can decode runtime API results using just the chain metadata, so we can more easily support future changes to the APIs.
This breaks old clients, but the timing with RAO makes it worthwhile, as old clients will break anyway.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

Clients upgrading should be grabbing their type information from the V15 Metadata on the chain.
They should also be able to see these runtime APIs listed there, with their expected input and output types, and the encoding for said types.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild marked this pull request as ready for review February 3, 2025 18:35
@camfairchild camfairchild requested a review from unconst as a code owner February 3, 2025 18:35
@camfairchild camfairchild added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Feb 3, 2025
sam0x17
sam0x17 previously approved these changes Feb 3, 2025
@camfairchild camfairchild removed the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Feb 3, 2025
@sam0x17 sam0x17 merged commit 86e898f into devnet-ready Feb 4, 2025
21 of 22 checks passed
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants