Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change types #1234

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Change types #1234

merged 2 commits into from
Feb 4, 2025

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Feb 4, 2025

Description

Change types so that math doesn't overflow or underflow.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor marked this pull request as ready for review February 4, 2025 19:18
@gztensor gztensor requested a review from unconst as a code owner February 4, 2025 19:18
@gztensor gztensor requested review from camfairchild and removed request for unconst February 4, 2025 19:18
@gztensor gztensor merged commit 0984944 into raoclaim Feb 4, 2025
10 of 12 checks passed
@gztensor gztensor deleted the fix/fractional-math-raoclaims branch February 4, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants