Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align chain flag in test nodes #325

Closed

Conversation

birkskyum
Copy link

@birkskyum birkskyum commented Apr 13, 2024

Of these places with test node configuration:

  • subtensor/docker-compose (raw_testspec)
  • subtensor/scripts/run/subtensor.sh (raw_spec)
  • subtensor/docs/running-subtensor-locally.md (raw_spec)
  • developer-docs/docs/subtensor-nodes/using-source.md (raw_spec)

Only the docker-compose.yml would set chain to raw_testspec.json instead of raw_spec.json. This aligns the docker-compose to the rest. Let me know if it's actually the 3 other places that should be aligned to the docker-compose.yml instead.

@distributedstatemachine
Copy link
Collaborator

Thanks for opening this issue!

With regards to changes in this PR , I dont think we need them , as the changes you introduce are changes the testnet docket compose builds to use the mainnet spec, which is not what we want.

I will defer to @rajkaramchedu to comment on the other docs

@birkskyum
Copy link
Author

birkskyum commented Apr 15, 2024

Interesting, I have had a lot of issues of hitting the main unintended lately, so if the raw_testspec is up-to-date and working as intended it would make sense if it's all the other places that needs altering (see #329).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants